Fix issues searching with a space in the search string (fix espruino/BangleApps#3898)

Author: gfwilliams

js/index.js

@@ -682,6 +682,8 @@ function refreshLibrary(options) {
           Utils.searchRelevance(app.description, searchValue)/5 + // match on description, but pay less attention
           ((app.tags && app.tags.includes(searchValue))?10:0)
       }));
+    } else {
+      console.warn("Unknown search type "+searchType, searchValue);
     }
     // Now finally, filter, sort based on relevance and set the search result
     visibleApps = searchResult.filter(a => a.relevance>0).sort((a,b) => (b.relevance-(0|b.sortorder)) - (a.relevance-(0|a.sortorder))).map(a => a.app);
@@ -690,11 +692,12 @@ function refreshLibrary(options) {
   if (!sortedByRelevance)
     visibleApps.sort(appSorter);
 
-  if (activeSort) {
+  if (activeSort && !searchValue) { // only sort if not searching (searching already sorts)
     if (["created","modified","installs","favourites"].includes(activeSort)) {
-      visibleApps = visibleApps.sort((a,b) =>
+      visibleApps = visibleApps.sort((a,b) => {
         ((appSortInfo[b.id]||{})[activeSort]||0) -
         ((appSortInfo[a.id]||{})[activeSort]||0));
+      });
     } else throw new Error("Unknown sort type "+activeSort);
   }
 

js/utils.js

@@ -338,6 +338,7 @@ function searchRelevance(value, searchString) {
   let partRelevance = 0;
   let valueParts = value.split(/[\s(),.-]/).filter(p=>p.length);
   searchString.split(/[\s-(),.-]/).forEach(search=>{
+    if (search==="") return; // ignore empty search strings
     valueParts.forEach(v=>{
       if (v==search)
         partRelevance += 20; // if a complete match, +20