Skip to content

Commit 64c8c25

Browse files
authored
Deserialising ADAr populates the dimensions field (#90)
1 parent 3c2564c commit 64c8c25

File tree

3 files changed

+5
-1
lines changed

3 files changed

+5
-1
lines changed

streaming_data_types/_version.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
# Version is not directly defined in __init__ because that causes all
22
# run time dependencies to become build-time dependencies when it is
33
# imported in setup.py
4-
version = "0.22.1"
4+
version = "0.23.0"

streaming_data_types/area_detector_ADAr.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -130,6 +130,7 @@ def serialise_ADAr(
130130
("source_name", str),
131131
("unique_id", int),
132132
("timestamp", datetime),
133+
("dimensions", np.ndarray),
133134
("data", np.ndarray),
134135
("attributes", List[Attribute]),
135136
),
@@ -200,6 +201,7 @@ def deserialise_ADAr(buffer: Union[bytearray, bytes]) -> ADArray:
200201
source_name=ad_array.SourceName().decode(),
201202
unique_id=unique_id,
202203
timestamp=datetime.fromtimestamp(used_timestamp, tz=timezone.utc),
204+
dimensions=ad_array.DimensionsAsNumpy(),
203205
data=data,
204206
attributes=attributes_list,
205207
)

tests/test_ADAr.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,8 @@ def test_serialises_and_deserialises_ADAr_int_array(self):
3636
assert entry.unique_id == original_entry["unique_id"]
3737
assert entry.source_name == original_entry["source_name"]
3838
assert entry.timestamp == original_entry["timestamp"]
39+
assert np.array_equal(entry.dimensions, original_entry["data"].shape)
40+
assert np.array_equal(entry.data.shape, entry.dimensions) # Sanity check
3941
assert np.array_equal(entry.data, original_entry["data"])
4042
assert entry.data.dtype == original_entry["data"].dtype
4143
assert len(entry.attributes) == len(original_entry["attributes"])

0 commit comments

Comments
 (0)