diff --git a/README.md b/README.md index d503561c..57d5faa1 100644 --- a/README.md +++ b/README.md @@ -152,7 +152,7 @@ You can use `new-mnemonic --help` to see all arguments. Note that if there are m | `--folder` | String. Pointing to `./validator_keys` by default | The folder path for the keystore(s) and deposit(s) | | `--chain` | String. `mainnet` by default | The chain setting for the signing domain. | | `--execution_address` (or `--eth1_withdrawal_address`) | String. Eth1 address in hexadecimal encoded form | If this field is set and valid, the given Eth1 address will be used to create the withdrawal credentials. Otherwise, it will generate withdrawal credentials with the mnemonic-derived withdrawal public key in [ERC-2334 format](https://eips.ethereum.org/EIPS/eip-2334#eth2-specific-parameters). | -| `--pbkdf2` | Flag | Will use pbkdf2 key derivation instead of scrypt as defined in EIP-2335. This can be a good alternative if you intend to work with a large number of keys. | +| `--pbkdf2` | Flag | Will use pbkdf2 key derivation instead of scrypt for generated keystore files as defined in EIP-2335. This can be a good alternative if you intend to work with a large number of keys. | ###### `existing-mnemonic` Arguments @@ -165,7 +165,7 @@ You can use `existing-mnemonic --help` to see all arguments. Note that if there | `--folder` | String. Pointing to `./validator_keys` by default | The folder path for the keystore(s) and deposit(s) | | `--chain` | String. `mainnet` by default | The chain setting for the signing domain. | | `--execution_address` (or `--eth1_withdrawal_address`) | String. Eth1 address in hexadecimal encoded form | If this field is set and valid, the given Eth1 address will be used to create the withdrawal credentials. Otherwise, it will generate withdrawal credentials with the mnemonic-derived withdrawal public key in [ERC-2334 format](https://eips.ethereum.org/EIPS/eip-2334#eth2-specific-parameters). | -| `--pbkdf2` | Flag | Will use pbkdf2 key derivation instead of scrypt as defined in EIP-2335. This can be a good alternative if you intend to work with a large number of keys. | +| `--pbkdf2` | Flag | Will use pbkdf2 key derivation instead of scrypt for generated keystore files as defined in EIP-2335. This can be a good alternative if you intend to work with a large number of keys. | ###### Successful message diff --git a/staking_deposit/cli/generate_keys.py b/staking_deposit/cli/generate_keys.py index 8ece1a04..bbf87ff5 100644 --- a/staking_deposit/cli/generate_keys.py +++ b/staking_deposit/cli/generate_keys.py @@ -109,7 +109,7 @@ def generate_keys_arguments_decorator(function: Callable[..., Any]) -> Callable[ default=False, is_flag=True, param_decls='--pbkdf2', - help='Uses the pbkdf2 encryption method instead of scrypt.', + help=lambda: load_text(['arg_pbkdf2', 'help'], func='generate_keys_arguments_decorator'), ), ] for decorator in reversed(decorators): diff --git a/staking_deposit/intl/en/cli/generate_keys.json b/staking_deposit/intl/en/cli/generate_keys.json index 4df4388f..612009ff 100644 --- a/staking_deposit/intl/en/cli/generate_keys.json +++ b/staking_deposit/intl/en/cli/generate_keys.json @@ -22,6 +22,9 @@ "prompt": "Please enter the optional 20-byte execution address for the new withdrawal credentials. Note that you CANNOT change it once you have set it on chain.", "confirm": "Repeat your execution address for confirmation.", "mismatch": "Error: the two entered values do not match. Please type again." + }, + "arg_pbkdf2": { + "help": "Uses the pbkdf2 hashing function instead of scrypt for generated keystore files. " } }, "generate_keys": {