From b3ca5456b01c55cf78367cf8c47a33a558bc0eed Mon Sep 17 00:00:00 2001 From: John McLear Date: Fri, 8 May 2026 10:57:36 +0100 Subject: [PATCH] fix(ci): drop pnpm version pin in npmpublish; rely on packageManager Same fix as ep_plugin_helpers#12. The publish job checks out etherpad-lite (pinned to pnpm@11 via packageManager) into cwd, then pnpm/action-setup@v6 errors on the version mismatch. Removing the 'version:' line lets action-setup take the version from packageManager (now pinned to pnpm@11.0.6 here too). --- .github/workflows/npmpublish.yml | 5 ++++- package.json | 1 + 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/.github/workflows/npmpublish.yml b/.github/workflows/npmpublish.yml index 2b8e28e..8d3b549 100644 --- a/.github/workflows/npmpublish.yml +++ b/.github/workflows/npmpublish.yml @@ -34,7 +34,10 @@ jobs: - uses: pnpm/action-setup@v6 name: Install pnpm with: - version: 10 + # No `version:` here — defer to packageManager in package.json so + # we don't clash with etherpad-lite's pnpm version pin (the + # checkout above puts its package.json at cwd). See + # pnpm/action-setup#225. run_install: false - name: Get pnpm store directory shell: bash diff --git a/package.json b/package.json index 888701f..d3cc10d 100644 --- a/package.json +++ b/package.json @@ -44,6 +44,7 @@ "supertest": "^7.0.0", "typescript": "^6.0.3" }, + "packageManager": "pnpm@11.0.6", "scripts": { "lint": "eslint .", "lint:fix": "eslint --fix .",