From 547d8f5dfe19f9f521bd95a5390ff04e02f7931c Mon Sep 17 00:00:00 2001 From: John McLear Date: Fri, 8 May 2026 10:52:04 +0100 Subject: [PATCH 1/2] fix(ci): drop hardcoded pnpm version 10, defer to packageManager The publish job checks out etherpad-lite core first (pinned to pnpm@11 via packageManager); pnpm/action-setup@v6 then errors with 'Multiple versions of pnpm specified' because the workflow's version: 10 clashes with the checked-out repo's packageManager. Removing 'version:' lets action-setup take pnpm@11 from packageManager, which is what we actually want for compatibility with the rest of the plugin ecosystem and what the test job already does. --- .github/workflows/npmpublish.yml | 5 ++++- .github/workflows/test-and-release.yml | 2 +- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/.github/workflows/npmpublish.yml b/.github/workflows/npmpublish.yml index 2b8e28e..8cf0b82 100644 --- a/.github/workflows/npmpublish.yml +++ b/.github/workflows/npmpublish.yml @@ -34,7 +34,10 @@ jobs: - uses: pnpm/action-setup@v6 name: Install pnpm with: - version: 10 + # No `version:` here — defer to packageManager in package.json so + # we don't get the "Multiple versions of pnpm specified" error + # when an upstream checkout (etherpad-lite) pins a different + # pnpm via packageManager. See pnpm/action-setup#225. run_install: false - name: Get pnpm store directory shell: bash diff --git a/.github/workflows/test-and-release.yml b/.github/workflows/test-and-release.yml index d0ec5d8..7852057 100644 --- a/.github/workflows/test-and-release.yml +++ b/.github/workflows/test-and-release.yml @@ -15,7 +15,7 @@ jobs: node-version: 20 - uses: pnpm/action-setup@v6 with: - version: 10 + # No `version:` — defer to packageManager in package.json. run_install: false - name: Get pnpm store directory shell: bash From 6a6fc11a61b3de7e863480416d7cff493713c49d Mon Sep 17 00:00:00 2001 From: John McLear Date: Fri, 8 May 2026 10:53:16 +0100 Subject: [PATCH 2/2] build: pin packageManager to pnpm@11.0.6 action-setup infers the pnpm version from this field. The test job doesn't check out an upstream repo, so without it action-setup errors 'No pnpm version is specified'. --- package.json | 1 + 1 file changed, 1 insertion(+) diff --git a/package.json b/package.json index 60e5af6..d19cd89 100644 --- a/package.json +++ b/package.json @@ -28,6 +28,7 @@ "type": "individual", "url": "https://etherpad.org/" }, + "packageManager": "pnpm@11.0.6", "scripts": { "lint": "eslint .", "lint:fix": "eslint --fix .",