Commit eb55314
fix(release): exclude etherpad/bin/ from extraResources to unbreak Win (#51)
The v0.4.2 release build cleared deb / snap / macOS / AppImage but
release-windows still failed. The 7za scan reports many warnings:
.\resources\etherpad\bin\node_modules\ep_etherpad-lite\node_modules\async\
: The system cannot find the path specified.
(and the same for cookie-parser, cross-env, cross-spawn, ejs, esbuild,
express, express-rate-limit, express-session, find-root, formidable,
http-errors, jose, js-cookie, jsdom, jsonminify, jsonwebtoken, ...)
7za exits 1 on warnings, electron-builder treats that as a build
failure, and the NSIS .exe never gets produced.
Etherpad's `bin/` directory is operator CLI utilities (compactPad,
importSqlFile, migrateDB, etc.) that the embedded server never
invokes at runtime. Its package.json declares a workspace symlink to
`../src`, and the nested
bin/node_modules/ep_etherpad-lite/node_modules/<dep>
paths are pnpm symlinks. Tar preserves them on extract; Linux/macOS
follow them, Windows can't.
Exclude `bin/**` from extraResources — findBundledEtherpadDir +
node/server.ts only need `src/`.
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>1 parent 75c69d4 commit eb55314
1 file changed
Lines changed: 12 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
39 | 39 | | |
40 | 40 | | |
41 | 41 | | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
42 | 54 | | |
43 | 55 | | |
44 | 56 | | |
| |||
0 commit comments