Skip to content

Commit eb55314

Browse files
JohnMcLearclaude
andauthored
fix(release): exclude etherpad/bin/ from extraResources to unbreak Win (#51)
The v0.4.2 release build cleared deb / snap / macOS / AppImage but release-windows still failed. The 7za scan reports many warnings: .\resources\etherpad\bin\node_modules\ep_etherpad-lite\node_modules\async\ : The system cannot find the path specified. (and the same for cookie-parser, cross-env, cross-spawn, ejs, esbuild, express, express-rate-limit, express-session, find-root, formidable, http-errors, jose, js-cookie, jsdom, jsonminify, jsonwebtoken, ...) 7za exits 1 on warnings, electron-builder treats that as a build failure, and the NSIS .exe never gets produced. Etherpad's `bin/` directory is operator CLI utilities (compactPad, importSqlFile, migrateDB, etc.) that the embedded server never invokes at runtime. Its package.json declares a workspace symlink to `../src`, and the nested bin/node_modules/ep_etherpad-lite/node_modules/<dep> paths are pnpm symlinks. Tar preserves them on extract; Linux/macOS follow them, Windows can't. Exclude `bin/**` from extraResources — findBundledEtherpadDir + node/server.ts only need `src/`. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent 75c69d4 commit eb55314

1 file changed

Lines changed: 12 additions & 0 deletions

File tree

packages/desktop/build/electron-builder.yml

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,18 @@ extraResources:
3939
- '!**/tests/**'
4040
- '!**/.git/**'
4141
- '!**/playwright.config.ts'
42+
# Etherpad's `bin/` directory contains operator CLI utilities
43+
# (compactPad, importSqlFile, etc.) that the embedded server
44+
# never invokes at runtime. Its package.json declares a pnpm
45+
# workspace symlink to `../src`, and the nested
46+
# `bin/node_modules/ep_etherpad-lite/node_modules/<dep>` paths
47+
# are pnpm symlinks too. tar/zip preserves the symlinks but
48+
# Windows file systems don't follow them after extraction, so
49+
# 7za scan-fails with "system cannot find the path specified"
50+
# for every dep and exits 1 (warning-as-error), breaking the
51+
# Windows NSIS build. Excluding the whole dir is fine —
52+
# findBundledEtherpadDir + node/server.ts only need src/.
53+
- '!bin/**'
4254

4355
asar: true
4456
asarUnpack:

0 commit comments

Comments
 (0)