-
Notifications
You must be signed in to change notification settings - Fork 154
(feat)ci: pypy3.11 support #1854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
97366f3
to
4d2d4f7
Compare
c7d453f
to
6b7c7aa
Compare
@@ -79,6 +79,7 @@ docs = [ | |||
"mkdocstrings-python>=1.0.0,<2", | |||
"pillow>=10.0.1,<11", | |||
"pyspelling>=2.8.2,<3", | |||
"lxml>=6.0.0,<7", # needs to be >= 6.0 for pypy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a dependency of pyspelling, and needs to be >=6.0 for pypy. pyspelling doesn't have any restriction on the version, so need to specify here. Could get more specific if we wanted - something along the lines of "lxml>=6.0.0,<7; implementation_name == 'pypy'",
7240fa0
to
b3b8c0f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing! Really nice to have this!
As a sanity check could you please:
- Compare cpython and pypy 3.11
fill
run times on this branch and cpython on main? - Diff the generated fixtures with pypy on this branch to fixtures generated on main? We use the
hasher
utitlity to diff? This should be adequate:
uv run fill -m "not slow and not benchmark" -n auto
I think the docs are a bit borked on this, but this comment explains how to do this:
#792 (review)
I absolutely recommend doing this on the hive server for speed!
Co-authored-by: danceratopz <[email protected]>
b381347
to
c9abf90
Compare
🗒️ Description
Allows this repo to run using pypy3.11. The new CI job runs in ~15m, which is generally ~30s-1m slower than our next slowest job. I'm happy to spend more time trying to get it down, but didn't know how much priority to give it here.
🔗 Related Issues or PRs
#1839
✅ Checklist
tox
checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx --with=tox-uv tox -e lint,typecheck,spellcheck,markdownlint
type(scope):
.