Added --log-to command-line argument to pytest logging plugin and configure tox environments to write logs to {toxworkdir}/logs

Author: DeborahOlaboye

packages/tests/src/pytest_plugins/custom_logging/plugin_logging.py

@@ -268,6 +268,13 @@ def pytest_addoption(parser: pytest.Parser) -> None:  # noqa: D103
             "CRITICAL, default - INFO. An integer in [0, 50] may be also provided."
         ),
     )
+    logging_group.addoption(
+        "--log-to",
+        action="store",
+        default=None,
+        dest="eest_log_dir",
+        help="Directory to write log files. Defaults to ./logs if not specified.",
+    )
 
 
 @functools.cache
@@ -317,16 +324,10 @@ def pytest_configure(config: pytest.Config) -> None:
 
     worker_id = os.getenv("PYTEST_XDIST_WORKER", "main")
     log_filename = f"{log_stem}-{worker_id}.log"
-    basetemp_opt = getattr(config.option, "basetemp", None)
-    tox_work_dir = os.environ.get("TOX_WORK_DIR")
-
-    if basetemp_opt:
-        base_logs_dir = Path(str(basetemp_opt)) / "logs"
-    elif tox_work_dir:
-        base_logs_dir = Path(tox_work_dir) / "logs"
-    else:
-        base_logs_dir = Path("logs")
 
+    # Use --log-to if provided, otherwise default to ./logs
+    log_dir = getattr(config.option, "eest_log_dir", None)
+    base_logs_dir = Path(log_dir) if log_dir else Path("logs")
     base_logs_dir.mkdir(parents=True, exist_ok=True)
     log_file_path = base_logs_dir / log_filename
 

tox.ini

@@ -63,6 +63,7 @@ commands =
         --cov-branch \
         --ignore-glob='tests/json_infra/fixtures/*' \
         --basetemp="{temp_dir}/pytest" \
+        --log-to "{toxworkdir}/logs" \
         tests/json_infra
 
 [testenv:py3]
@@ -73,6 +74,7 @@ commands =
         -m "not slow and not zkevm and not benchmark" \
         -n auto --maxprocesses 10 --dist=loadgroup \
         --basetemp="{temp_dir}/pytest" \
+        --log-to "{toxworkdir}/logs" \
         --clean \
         --until Osaka \
         tests
@@ -93,6 +95,7 @@ commands =
         -m "not slow and not zkevm and not benchmark" \
         -n auto --maxprocesses 7 --dist=loadgroup \
         --basetemp="{temp_dir}/pytest" \
+        --log-to "{toxworkdir}/logs" \
         --clean \
         --until Osaka \
         tests
@@ -112,6 +115,7 @@ commands =
         --ignore-glob='tests/test_t8n.py' \
         --ignore-glob='eest_tests/*' \
         --basetemp="{temp_dir}/pytest" \
+        --log-to "{toxworkdir}/logs" \
         --optimized \
         tests/json_infra