eth: resolve finalized from disk if it's not recently announced #33150
+4
−28
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains two changes:
Firstly, the finalized header will be resolved from local chain if it's not recently
announced via the
engine_newPayload.What's more importantly is, in the downloader, originally there are two code paths
to push forward the pivot point block, one in the beacon header fetcher (
fetchHeaders),and another one is in the snap content processer (
processSnapSyncContent).Usually if there are new blocks and local pivot block becomes stale, it will firstly be
detected by the
fetchHeaders.processSnapSyncContentis fully driven by thebeacon headers and will only detect the stale pivot block after synchronizing the
corresponding chain segment. I think the detection here is redundant and useless.