Skip to content

Commit ee1a004

Browse files
committed
fix broken rebase things
1 parent 360f6ea commit ee1a004

File tree

6 files changed

+11
-21
lines changed

6 files changed

+11
-21
lines changed

populus/chain/__init__.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,3 @@
1-
from populus.contracts.exceptions import ( # noqa: F401
2-
NoKnownAddress,
3-
UnknownContract,
4-
BytecodeMismatchError,
5-
)
6-
71
from .geth import ( # noqa: F401
82
BaseGethChain,
93
LocalGethChain,

populus/chain/base.py

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,11 +57,16 @@ def initialize_chain(self):
5757
#
5858
# Context manager API
5959
#
60+
_running = None
61+
6062
def __enter__(self):
61-
raise NotImplementedError("Must be implemented by subclasses")
63+
self._running = True
64+
return self
6265

6366
def __exit__(self, exc_type, exc_val, exc_tb):
64-
pass
67+
if not self._running:
68+
raise ValueError("The TesterChain is not running")
69+
self._running = False
6570

6671
#
6772
# Chain Interaction API

populus/chain/external.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,5 +4,4 @@
44

55

66
class ExternalChain(BaseChain):
7-
def __enter__(self):
8-
return self
7+
pass

populus/chain/geth.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,6 @@ def get_geth_process_instance(self):
9999
def get_web3_config(self):
100100
web3_config = copy.deepcopy(super(BaseGethChain, self).get_web3_config())
101101
web3_config['provider.settings.ipc_path'] = self.geth.ipc_path
102-
web3_config['provider.settings.rpc_port'] = self.geth.rpc_port
103102
return web3_config
104103

105104
def __enter__(self, *args, **kwargs):

populus/chain/tester.py

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
from .base import (
2-
BaseTesterChain,
2+
BaseChain,
33
)
44

55

6-
class TesterChain(BaseTesterChain):
6+
class TesterChain(BaseChain):
77
_running = False
88

99
def __enter__(self):
@@ -24,8 +24,3 @@ def __enter__(self):
2424
self.rpc_methods = self.web3.currentProvider.rpc_methods
2525

2626
return self
27-
28-
def __exit__(self, *exc_info):
29-
if not self._running:
30-
raise ValueError("The TesterChain is not running")
31-
self._running = False

populus/chain/testrpc.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,13 +19,11 @@ def get_web3_config(self):
1919
config['provider.settings.port'] = self.rpc_port
2020
return config
2121

22-
_running = None
23-
2422
def __enter__(self):
2523
if self._running:
2624
raise ValueError("The TesterChain is already running")
2725

28-
if self.port is None:
26+
if self.rpc_port is None:
2927
self.rpc_port = get_open_port()
3028

3129
self._running = True

0 commit comments

Comments
 (0)