Make Trin compilable on Windows

Author: KolbyML

Cargo.lock

@@ -24,7 +24,6 @@ parking_lot = "0.11.2"
 portalnet = { path = "portalnet" }
 prometheus_exporter = "0.8.4"
 rand = "0.8.4"
-reth-ipc = { version = "0.1.0", git = "https://github.com/paradigmxyz/reth.git"}
 rlp = "0.5.0"
 rocksdb = "0.18.0"
 rpc = { path = "rpc"}
@@ -44,6 +43,9 @@ trin-utils = { path = "trin-utils" }
 trin-validation = { path = "trin-validation" }
 utp-rs = "0.1.0-alpha.4"
 
+[target.'cfg(not(windows))'.dependencies]
+reth-ipc = { version = "0.1.0", git = "https://github.com/paradigmxyz/reth.git"}
+
 [dev-dependencies]
 ethportal-peertest = { path = "ethportal-peertest" }
 ureq = { version = "2.5.0", features = ["json"] }

Cargo.toml

@@ -23,7 +23,7 @@ hex = "0.4.3"
 hyper = { version = "0.14", features = ["full"] }
 jsonrpsee = {version="0.16.2", features = ["async-client", "client", "macros", "server"]}
 rand = "0.8.4"
-reth-ipc = { version = "0.1.0", git = "https://github.com/paradigmxyz/reth.git"}
+
 rocksdb = "0.18.0"
 serde_json = "1.0.89"
 structopt = "0.3.26"
@@ -39,5 +39,5 @@ trin-types = { path = "../trin-types" }
 trin-utils = { path = "../trin-utils" }
 ureq = { version = "2.5.0", features = ["json"] }
 
-[target.'cfg(windows)'.dependencies]
-uds_windows = "1.0.1"
+[target.'cfg(not(windows))'.dependencies]
+reth-ipc = { version = "0.1.0", git = "https://github.com/paradigmxyz/reth.git"}

ethportal-peertest/Cargo.toml

@@ -1,3 +1,4 @@
+#![cfg(unix)]
 pub mod constants;
 pub mod scenarios;
 

ethportal-peertest/src/lib.rs

@@ -0,0 +1,3 @@
+### fix windows compilation
+
+add cfg and add a few panics to clearly define what is not supported by windows so it can compile

newsfragments/739.fixed.md

@@ -50,9 +50,6 @@ validator = { version = "0.13.0", features = ["derive"] }
 url = "2.3.1"
 utp-rs = "0.1.0-alpha.4"
 
-[target.'cfg(windows)'.dependencies]
-uds_windows = "1.0.1"
-
 [dev-dependencies]
 env_logger = "0.9.0"
 quickcheck = "1.0.3"

portalnet/Cargo.toml

@@ -17,6 +17,8 @@ portalnet = { path = "../portalnet"}
 trin-types = { path = "../trin-types"}
 trin-utils = { path = "../trin-utils"}
 tokio = { version = "1.14.0", features = ["full"] }
-reth-ipc = { version = "0.1.0", git = "https://github.com/paradigmxyz/reth.git"}
 url = "2.3.1"
 serde_json = "1.0.95"
+
+[target.'cfg(not(windows))'.dependencies]
+reth-ipc = { version = "0.1.0", git = "https://github.com/paradigmxyz/reth.git"}

rpc/Cargo.toml

@@ -2,6 +2,7 @@ use crate::jsonrpsee::server::{ServerBuilder as HttpServerBuilder, ServerHandle}
 use crate::{Discv5Api, HistoryNetworkApi, Web3Api};
 use ethportal_api::{Discv5ApiServer, HistoryNetworkApiServer, Web3ApiServer};
 use portalnet::discovery::Discovery;
+#[cfg(unix)]
 use reth_ipc::server::Builder as IpcServerBuilder;
 use std::net::SocketAddr;
 use std::path::Path;
@@ -31,6 +32,7 @@ impl JsonRpcServer {
         Ok(handle)
     }
 
+    #[cfg(unix)]
     pub async fn run_ipc(
         ipc_path: Box<dyn AsRef<Path>>,
         discv5: Arc<Discovery>,
@@ -46,4 +48,13 @@ impl JsonRpcServer {
         let handle = server.start(api).await?;
         Ok(handle)
     }
+
+    #[cfg(windows)]
+    pub async fn run_ipc(
+        _ipc_path: Box<dyn AsRef<Path>>,
+        _discv5: Arc<Discovery>,
+        _history_handler: mpsc::UnboundedSender<HistoryJsonRpcRequest>,
+    ) -> anyhow::Result<ServerHandle> {
+        panic!("Windows doesn't support Unix Domain Sockets IPC, use --web3-transport http")
+    }
 }

rpc/src/server_rpc.rs

@@ -1,4 +1,4 @@
-#[cfg(test)]
+#[cfg(all(unix, test))]
 mod test {
     use std::{
         net::{IpAddr, Ipv4Addr},

tests/self_peertest.rs

@@ -26,6 +26,9 @@ trin-types = { path = "../trin-types" }
 trin-utils = { path = "../trin-utils" }
 ureq = { version = "2.5.0", features = ["json"] }
 
+[target.'cfg(windows)'.dependencies]
+uds_windows = "1.0.1"
+
 [[bin]]
 name="trin-cli"
 path="src/main.rs"