Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

browse.recordings bugged? #85

Closed
tiagocpontesp opened this issue Sep 16, 2018 · 1 comment
Closed

browse.recordings bugged? #85

tiagocpontesp opened this issue Sep 16, 2018 · 1 comment
Labels

Comments

@tiagocpontesp
Copy link

  • getting
graphbrainz:api/client Error: “Error: ESOCKETTIMEDOUT” url=http://musicbrainz.org/ws/2/undefined/560b15db-79ea-49c0-b26e-84c808986e99?inc=artist-credit
  • which isn't accessing

https://musicbrainz.org/ws/2/recording/560b15db-79ea-49c0-b26e-84c808986e99?inc=artist-credits
(both the query parameter and entity are wrong)

  • on the query:
{
   browse {
    recordings(isrc:"GBUM70601491") {
      nodes {
        id
        mbid
        title
        length
        artistCredits {
          name
        }
      }
    }
  }
}

thank you.

@exogen
Copy link
Owner

exogen commented Sep 16, 2018

Unfortunately I hardly understand my own query resolver code anymore and it's due for a refactoring. 😄 A rewrite is in the works to make it clearer and much faster due to batching (see #78).

In the meantime, here's a fix for ISRC browsing and artistCredits in particular: #86.

Similar fields like ISWC probably also need fixes but I've left that as an exercise for later.

@exogen exogen added the bug label Sep 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants