Skip to content

Notifier Refactoring (NotifierContentPane) #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
oliverp opened this issue Apr 4, 2011 · 0 comments
Open

Notifier Refactoring (NotifierContentPane) #1

oliverp opened this issue Apr 4, 2011 · 0 comments
Assignees

Comments

@oliverp
Copy link
Contributor

oliverp commented Apr 4, 2011

As a developer i need a clear and crispy API for the notifier component. Currently the notifier is binded to the body and is missing the connection to the echo component.

Idea:

Make the notifier API accessible through a specialized ContentPane (NotifierContentPane).

Target code:
contentPane.show(notification);

The Notifier is currently a kind of hack because of:

it can only work if it is a child of the ContentPane (echo3 restriction)
there maybe multiple instances per application but all of them share the "body" html element
notification-messages are not "send" to the notifier. Instead all notifier properties are replaced. This update event triggers the "show a new notification" method in the actual jquery notifier

The refactoring shall include:

The notifier-api is part of a specialized "ContentPane". Each ContentPane has its own stack of "NotificationMessages". This allows e.g. Notifications inside windows etc.
The notification-message is a complex object that is sent "as value" to the notifier

@ghost ghost assigned oliverp Apr 11, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant