Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lighting issue when showing edges on a textured .gltf #1008

Closed
mwestphal opened this issue Sep 30, 2023 · 5 comments
Closed

Lighting issue when showing edges on a textured .gltf #1008

mwestphal opened this issue Sep 30, 2023 · 5 comments
Milestone
2.3.0

Comments

@mwestphal
Copy link
Contributor

Describe the bug

Lighting is wrong when showing edges of a textured .gltf

f3d -e file.gltf

a

a

a

No problem with a non-textured gltf:

a

Nor with a textured obj or fbx:

a

a
@mwestphal
Copy link
Contributor Author

Regression between 2.0 and 2.1, should be bisected

@mwestphal mwestphal added this to the 2.3.0 milestone Sep 30, 2023
@Meakk
Copy link
Member

Meakk commented Sep 30, 2023

Looks related to the PBR shader. Should not be too hard to fix. Do you want me to take a look before the final release?

@mwestphal
Copy link
Contributor Author

That can wait 2.3 tbh, nobody found it in the last three months.

@Meakk
Copy link
Member

Meakk commented Nov 14, 2023

VTK fix: https://gitlab.kitware.com/vtk/vtk/-/merge_requests/10705

@mwestphal
Copy link
Contributor Author

a

Confirmed fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.3.0
Development

No branches or pull requests
2 participants
@mwestphal @Meakk