Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve logging #1111

Merged
merged 4 commits into from
Dec 22, 2023
Merged

Improve logging #1111

merged 4 commits into from
Dec 22, 2023

Conversation

mwestphal
Copy link
Member

@mwestphal mwestphal commented Dec 21, 2023 •
edited
Loading

Example output:

[glow@frollo ~/dev/f3d/f3d/build]$ ./bin/f3d ../src/testing/data/cow.vtp  --verbose 
========== Initializing ==========
Loading plugin "exodus"
  Version: 1.0
  Description: VTK Exodus support
  Readers:
    Exodus II
Loading plugin "native"
  Version: 1.0
  Description: Native VTK I/O support
  Readers:
    Autodesk 3D Studio
    CityGML
    DICOM
    GL Transmission Format
    MetaImage
    Nearly Raw Raster Data
    Wavefront OBJ
    Polygon
    Point Cloud
    Standard Triangle Language
    TIFF
    VRML
    VTK Legacy
    VTK XML UnstructuredGrid
    VTK XML PolyData
    VTK XML ImageData
    VTK XML RectangularGrid
    VTK XML StructuredGrid
    VTK XML MultiBlock
No configuration file for "config" found
========== Configuring engine ==========
Engine configured
========== Loading 3D file ==========
Loading 3D geometry: /home/glow/dev/f3d/f3d/build/../src/testing/data/cow.vtp

No animations available in this file

Animation(s) time range is: [inf, -inf].
=== cow.vtp ===
Number of points: 2903
Number of polygons: 3263
Number of lines: 0
Number of vertices: 0
0 point data array(s):
0 cell data array(s):


Not coloring

Scene bounding box: -4.44584,5.99809,-3.63704,2.75972,-1.70141,1.70141

Camera position: 0.776126,-0.438658,24.556
Camera focal point: 0.776126,-0.438658,0
Camera view up: 0,1,0
Camera view angle: 30


========== Rendering ==========
Render done

@mwestphal mwestphal mentioned this pull request Dec 21, 2023
Closed
@mwestphal mwestphal force-pushed the improve_logging branch 2 times, most recently from 7b4d5f7 to fc9d56b Compare December 21, 2023 14:35
@codecov Codecov
Copy link

codecov bot commented Dec 21, 2023 •
edited
Loading

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (e5dee4f) 96.45% compared to head (f134ad2) 96.45%.
Report is 2 commits behind head on master.

Files Patch % Lines
application/F3DStarter.cxx 92.85% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1111   +/-   ##
=======================================
  Coverage   96.45%   96.45%           
=======================================
  Files         124      124           
  Lines        7724     7739   +15     
=======================================
+ Hits         7450     7465   +15     
  Misses        274      274

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mwestphal mwestphal requested a review from Meakk December 22, 2023 11:18
@mwestphal mwestphal merged commit c374385 into f3d-app:master Dec 22, 2023
mwestphal added a commit that referenced this pull request Feb 10, 2024
@mwestphal
Merge pull request #1111 from mwestphal/improve_logging
5d67342 
Improve logging
mwestphalnew pushed a commit to mwestphalnew/f3d that referenced this pull request Feb 10, 2024
@mwestphal
Merge pull request f3d-app#1111 from mwestphal/improve_logging
e428088 
Improve logging
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Meakk Meakk Meakk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

F3D exits with error code 0 (success) despite an error having occurred (invalid json config file)
2 participants
@mwestphal @Meakk