Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 3MF support using assimp plugin #1126

Closed
mwestphal opened this issue Dec 25, 2023 · 11 comments
Closed

Add 3MF support using assimp plugin #1126

mwestphal opened this issue Dec 25, 2023 · 11 comments
Assignees
Labels
help wanted Please help with this issue!
Milestone

Comments

@mwestphal
Copy link
Contributor

Assimp library support 3MF format, lets add support for it

Related to: #38

Testing with #1123 , I tested the (single!) data from https://github.com/assimp/assimp and the data from https://github.com/3MFConsortium/3mf-samples/tree/master/examples

It looks like:

  • Texture seems non fonctionnal with the "core" datasets. It looks like the texture logic is a bit different that what we expect.
  • Many more complex files from "material" and "production" datasets are crashing.
  • Datasets from the "beam lattice" are outputting empty output
  • Datasets from the "slices" folder seems to be crashing for allocation size reason

More work needed before merging anything

@Meakk
Copy link
Member

Meakk commented Dec 28, 2023

Thanks for investigating. Do you know if the crashes are coming from assimp or f3d?

@mwestphal
Copy link
Contributor Author

crashes are coming from F3D most of the time. I would say the resulting data is not how F3D is expecting it.

@jtlechem
Copy link

jtlechem commented Jan 2, 2024

Will 3MF support include the ability to obtain part volume and bounding box?

@mwestphal mwestphal added this to the 2.3.0 milestone Jan 6, 2024
@mwestphal mwestphal added the help wanted Please help with this issue! label Jan 7, 2024
@mwestphal
Copy link
Contributor Author

Will 3MF support include the ability to obtain part volume and bounding box?

I'm not sure what that means.

@mwestphal
Copy link
Contributor Author

#1138

@jtlechem
Copy link

jtlechem commented Jan 8, 2024

Will 3MF support include the ability to obtain part volume and bounding box?

I'm not sure what that means.

I see your comment pointing to issue #1138. Perhaps I should have asked my question there.
But I'll try to explain what I mean. When I open my .3mf part in f3d, will the app tell me the volume of the part? I'm also interested in the 3d bounding box of the part - the largest x, y, and z dimensions of the part relative to the base frame.

@Meakk
Copy link
Member

Meakk commented Jan 8, 2024

@jtlechem can you share your file?

@jtlechem
Copy link

jtlechem commented Jan 8, 2024

I haven't downloaded f3d to try .3mf files yet, but I just wondered if these functionalities exist before I download it.

Here is a better illustration. Here you can see the object volume as well as the x, y, z dimensions of the box around the object relative to the ground coordinate frame shown in the bottom left. The 'bounding box' is visualized by the white lines around the object. Note the volume is that of the object, not the volume of the bounding box.
image
image

These are my own screenshots from PrusaSlicer, but I'm looking for a fast minimalist 3d viewer (like f3d) where I can rotate the object then get this information from the command line.
(also, I can't upload a .3mf file, it's not supported by github)

@Meakk
Copy link
Member

Meakk commented Jan 8, 2024

You can zip the file before sending it on github.
Regarding the bounding box with f3d, it's printed in the console, but there's no feature to visualize it (yet).

@mwestphal
Copy link
Contributor Author

but there's no feature to visualize it (yet).

Interesting idea, create an issue for it maybe ? :)

@Meakk Meakk closed this as completed Jan 8, 2024
@mwestphal
Copy link
Contributor Author

Available in the nightly release https://github.com/f3d-app/f3d/releases/tag/nightly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Please help with this issue!
Projects
None yet
Development

No branches or pull requests

3 participants