Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to f3d web model url parsing feature #1604

Open
4 tasks done
Tracked by #1929
jo-chemla opened this issue Sep 5, 2024 · 2 comments
Open
4 tasks done
Tracked by #1929

Improvements to f3d web model url parsing feature #1604

jo-chemla opened this issue Sep 5, 2024 · 2 comments
Milestone

Comments

@jo-chemla
Copy link
Contributor

jo-chemla commented Sep 5, 2024

Following PR #1596 and issue #1595
Here is a thread to discuss possible improvements to the model url parsing implementation of f3d web, after some discussion on the f3d discord

Quick notes parsing through the discussion

  • parse more url-params like up-vector, widgets, rendering, lighting
  • Visual feedback for download (can be done via fetch, more recent browser api than xhr)
  • Document feature
  • Detect cors and inform user, or any 404

Sidenotes,

  • Search query vs hash can be parsed and not necessarily sent to server, that's more standard than hashes
  • Bundling, ts module loaded in browser without need to build
@jo-chemla
Copy link
Contributor Author

Quick PR solving the above listed elements: #1738

@mwestphal mwestphal added this to the 3.1.0 milestone Dec 19, 2024
@jo-chemla
Copy link
Contributor Author

PR has been updated, mergeable with newest master branch from my point-of-view!

@mwestphal mwestphal mentioned this issue Feb 27, 2025
35 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Investigate
Development

No branches or pull requests

2 participants