Skip to content

Commit 7243111

Browse files
[All] Fix BuildalyzerCracker so it can work on .NET 10 (#4269)
Co-authored-by: Copilot <[email protected]>
1 parent bf1b212 commit 7243111

9 files changed

+24
-1
lines changed

NuGet.Config

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,28 @@
22
<configuration>
33
<packageSources>
44
<clear />
5+
<!--
6+
BuildAlyzer has a bug with .NET 10, there is a fix available since 1 month
7+
but no sign of a release for now.
8+
9+
For this reason, we want to use a local version of BuildAlyzer with the fix included
10+
and remove our own version later on.
11+
12+
See:
13+
- https://github.com/Buildalyzer/Buildalyzer/issues/318
14+
- https://github.com/Buildalyzer/Buildalyzer/pull/319
15+
16+
To build the custom version of Buildalyzer
17+
18+
1. Clone https://github.com/Buildalyzer/Buildalyzer
19+
2. Comment all `<PackageValidationBaselineVersion>` lines (in the 3 projects). I was not able to make dotnet pack work with it
20+
3. Run `dotnet build -c Release && dotnet pack -p:Version=8.0.0-fable-001`
21+
4. Copy the `*nupkg` and `*.snupkg` to the Fable `LocalPackages` folder.
22+
23+
cp **/bin/**/*.nupkg <path-to>/LocalPackages/
24+
cp **/bin/**/*.snupkg <path-to>/LocalPackages/
25+
-->
26+
<add key="LocalPackages" value="local-packages" />
527
<add key="NuGet.org" value="https://api.nuget.org/v3/index.json" />
628
</packageSources>
729
<disabledPackageSources>
112 KB
Binary file not shown.
42.5 KB
Binary file not shown.
31.5 KB
Binary file not shown.
7.38 KB
Binary file not shown.
33.8 KB
Binary file not shown.
21.7 KB
Binary file not shown.

src/Fable.Cli/CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
1111

1212
* [All] Fix `--cwd` with quoted paths (by @MangelMaxime)
1313
* [All] Fix `--legacyCracker` flag logic (by @MangelMaxime)
14+
* [All] Fix `BuildalyzerCracker` so it can work on .NET 10 (by @MangelMaxime)
1415

1516
### Changed
1617

src/Fable.Cli/Fable.Cli.fsproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@
4242
<Reference Include="../../lib/fcs/FSharp.Core.dll" />
4343
</ItemGroup>
4444
<ItemGroup>
45-
<PackageReference Include="Buildalyzer" Version="7.1.0" />
45+
<PackageReference Include="Buildalyzer" Version="8.0.0-fable-001" />
4646
<PackageReference Include="EasyBuild.PackageReleaseNotes.Tasks" Version="2.0.0">
4747
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
4848
<PrivateAssets>all</PrivateAssets>

0 commit comments

Comments
 (0)