New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rsync() generates invalid rsync command line if IPv6 address used #15

Open

makhomed opened this issue Oct 28, 2017 · 0 comments

makhomed commented Oct 28, 2017

bug in rsync() function fom patchwork/transfers.py:

if env.host.count(':') > 1:
        # Square brackets are mandatory for IPv6 rsync address,
        # even if port number is not specified
        cmd = "rsync %s %s [%s@%s]:%s" % (options, source, user, host, target)
    else:
        cmd = "rsync %s %s %s@%s:%s" % (options, source, user, host, target)

for IPv6 rsync address be "%s@[%s]", not "[%s@%s]" as it is now.

patchwork source code: https://github.com/fabric/patchwork/blob/master/patchwork/transfers.py#L111

details about IPv6 adresses with rsync: https://serverfault.com/questions/420158

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment