Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readability/improvements to asset filter function #46

Open
mattlub opened this issue Feb 11, 2018 · 0 comments
Open

readability/improvements to asset filter function #46

mattlub opened this issue Feb 11, 2018 · 0 comments

Comments

@mattlub
Copy link

mattlub commented Feb 11, 2018

To improve slightly here

3 things:

  • instead of indexOf() !== -1, includes is more semantic - docs
  • I would separate out the search term into a variable, so it reads more like asset.name.includes(searchTerm)
  • The search term could be simplified, after you note that this.state.search.length !== 0 could be replaced by this.state.search, since it's a string (and "" is falsey).
@mattlub mattlub changed the title readability of asset filter function readability/improvements to asset filter function Feb 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant