Skip to content

issues Search Results · repo:fac-13/HEII-topics language:JavaScript

Filter by

58 results
 (75 ms)

58 results

infac-13/HEII-topics (press backspace or delete to remove)

What s a comment, how do I see it and how do I make it!? I m guessing you didn t get around to making this exciting piece of functionality, so maybe consider removing it from your html for now so your ...
  • lucymk
  • Opened 
    on Apr 13, 2018
  • #82

It s great practice to delete your branches once they ve been merged or you re done with them, so you don t end up with a wild garden 🌲🌳🌴🌱🌵
  • lucymk
  • Opened 
    on Apr 13, 2018
  • #81

You set the .is-hidden class to the submitError element a total of 3 times, twice in dom.js and once in the index.html 😄 screen shot 2018-04-13 at 10 46 04
  • lucymk
  • Opened 
    on Apr 13, 2018
  • #80

I saw you are using cookies to return error messages from the backend to the frontend of your website. I think you adopted this solution because your forms use the default POST method to send data to ...
  • GiuliaTeggi
  • Opened 
    on Apr 13, 2018
  • #79

I have seen this wrapping of the input field within its label element a lot and I don t really understand it - is it a best practice or something? --- If the label is correctly associated to the input ...
  • haydnba
  • Opened 
    on Apr 13, 2018
  • #78

I forgot about this - very sensible... very DRY... 🌷 https://github.com/fac-13/HEII-topics/blob/f41463854fd77518befea620544c589775fd8499/public/index.js#L2-L6
compliment
  • haydnba
  • Opened 
    on Apr 13, 2018
  • #77

You should consider hiding your login/reg forms upon successful authentication, as part of visual cues to user that they are logged in.
  • vlbee
  • 1
  • Opened 
    on Apr 13, 2018
  • #76

Similar to Tom s issue, even if I do a hard refresh I still have my sorry there was a problem posting your vote error. There s also no way for me to logout except by physically deleting my jwt myself - ...
  • lucymk
  • Opened 
    on Apr 13, 2018
  • #75

It might be good to have feedback for your logged-in state somewhere on the page (apart from the initial message upon login), so the user knows when they are logged in or not.
  • tdoran
  • Opened 
    on Apr 13, 2018
  • #74

After successfully registering, the Thank you for registering with us message persists at the top on when I reload. Maybe because it is reading the message from the jwt every time I load the page.
  • tdoran
  • Opened 
    on Apr 13, 2018
  • #73
Issue origami icon

Learn how you can use GitHub Issues to plan and track your work.

Save views for sprints, backlogs, teams, or releases. Rank, sort, and filter issues to suit the occasion. The possibilities are endless.Learn more about GitHub Issues
ProTip! 
Restrict your search to the title by using the in:title qualifier.
Issue origami icon

Learn how you can use GitHub Issues to plan and track your work.

Save views for sprints, backlogs, teams, or releases. Rank, sort, and filter issues to suit the occasion. The possibilities are endless.Learn more about GitHub Issues
ProTip! 
Restrict your search to the title by using the in:title qualifier.
Issue search results · GitHub