Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UNSAFE_componentWillMount() #10

Open
oliverjam opened this issue May 25, 2018 · 0 comments
Open

UNSAFE_componentWillMount() #10

oliverjam opened this issue May 25, 2018 · 0 comments
Assignees
@iPhatty
Labels
DONE

Comments

@oliverjam
Copy link

You probably don't need to use UNSAFE_componentWillMount()—you can start the game inside componentDidMount()`. Is there any reason you picked this lifecycle instead?
@iPhatty iPhatty self-assigned this May 25, 2018
iPhatty added a commit that referenced this issue May 25, 2018
@iPhatty
change UNSAFE_componentWillMount to componentDidMount
367ee0a 
Relates #10
@helenzhou6 helenzhou6 added the DONE label Jun 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iPhatty iPhatty

Labels
DONE
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@oliverjam @helenzhou6 @iPhatty