Skip to content

issues Search Results · repo:fac-13/Tonnah language:JavaScript

Filter by

6 results
 (61 ms)

6 results

infac-13/Tonnah (press backspace or delete to remove)

fac-13/Tonnah
Use functional components

It s a bit simpler to write functional/stateless components if you don t need to use state or lifecycle methods. For example your photogroup and singlephoto components don t need to be classes.
completed
  • oliverjam
  • Opened 
    on May 25, 2018
  • #15

fac-13/Tonnah
index used as key

Indexes shouldn t be used as keys in react as it doesn t work properly for react s diffing. https://github.com/fac-13/Tonnah/blob/c657af9d802b61fbc9742d584caf281c2b0425b4/src/components/board/photogroup/photogroup.js#L12 ...
completed
  • ZooeyMiller
  • Opened 
    on May 25, 2018
  • #14

fac-13/Tonnah
missing alt text on images

https://github.com/fac-13/Tonnah/blob/c657af9d802b61fbc9742d584caf281c2b0425b4/src/components/board/singlephoto/singlephoto.js#L6 plz use alt text 🙏
completed
  • ZooeyMiller
  • Opened 
    on May 25, 2018
  • #13

fac-13/Tonnah
Amazing!

Such a fun game to play! Love your concept and layout. Very responsive and captivating! Fantastic work for a day s project :+1: :+1: :+1: :+1: :heart:
  • n1c0z
  • Opened 
    on May 25, 2018
  • #12

fac-13/Tonnah
Unnecessary Fragment

This fragment essentially serves no purpose as only a single component (of value) is being returned you can do away with it. This is a nitpick (😄) but with react its easy for components to get cluttered ...
completed
  • akinsho
  • 1
  • Opened 
    on May 25, 2018
  • #11

fac-13/Tonnah
Empty README.md

Hi 👋 One of the first things that you should consider 🤔 when working on any project is creating a readme so that both you, anyone you re collaborating with and potential users have an idea of what the ...
  • akinsho
  • Opened 
    on May 25, 2018
  • #10
Issue origami icon

Learn how you can use GitHub Issues to plan and track your work.

Save views for sprints, backlogs, teams, or releases. Rank, sort, and filter issues to suit the occasion. The possibilities are endless.Learn more about GitHub Issues
ProTip! 
Restrict your search to the title by using the in:title qualifier.
Issue origami icon

Learn how you can use GitHub Issues to plan and track your work.

Save views for sprints, backlogs, teams, or releases. Rank, sort, and filter issues to suit the occasion. The possibilities are endless.Learn more about GitHub Issues
ProTip! 
Restrict your search to the title by using the in:title qualifier.
Issue search results · GitHub