Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error handling #30

Open
Jbarget opened this issue Apr 20, 2018 · 1 comment
Open

Error handling #30

Jbarget opened this issue Apr 20, 2018 · 1 comment
Assignees
@n1c0z @iPhatty
Labels
done

Comments

@Jbarget
Copy link

Jbarget commented Apr 20, 2018

Imagine its just a running out of time thing but error handling here would be quite important

https://github.com/fac-13/crypt-os/blob/master/src/controllers/coin.js#L39
@helenzhou6
Copy link

And here too:

crypt-os/src/model/database/db_build.js

Line 14 in 8fdbafc

.catch(e => console.error('error: ', e));

@iPhatty iPhatty self-assigned this Apr 20, 2018
@iPhatty iPhatty added the done label Apr 20, 2018
iPhatty added a commit that referenced this issue Apr 20, 2018
@iPhatty
catch responds with 500 status error
fb98f62 
Relates #30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@n1c0z n1c0z

@iPhatty iPhatty

Labels
done
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Jbarget @n1c0z @helenzhou6 @iPhatty