You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I left a bunch of issues, but they were mostly either nitpicking or stuff that I thought would be useful for future reference, not anything I'd really have expected at this stage on a 1.5 day project.
Your commit history and github workflow seems pretty good, despite the odd empty PR description (you've even got a couple of "related to #<issue_number>"!).
Pleased to see pretty good error handling too, there's not really any cases where the client will be left hanging.
Nice work! 🥇
The text was updated successfully, but these errors were encountered:
I left a bunch of issues, but they were mostly either nitpicking or stuff that I thought would be useful for future reference, not anything I'd really have expected at this stage on a 1.5 day project.
Your commit history and github workflow seems pretty good, despite the odd empty PR description (you've even got a couple of "related to #<issue_number>"!).
Pleased to see pretty good error handling too, there's not really any cases where the client will be left hanging.
Nice work! 🥇
The text was updated successfully, but these errors were encountered: