Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Good job #46

Open
eliasmalik opened this issue Mar 29, 2018 · 0 comments
Open

Good job #46

eliasmalik opened this issue Mar 29, 2018 · 0 comments

Comments

@eliasmalik
Copy link

I left a bunch of issues, but they were mostly either nitpicking or stuff that I thought would be useful for future reference, not anything I'd really have expected at this stage on a 1.5 day project.

Your commit history and github workflow seems pretty good, despite the odd empty PR description (you've even got a couple of "related to #<issue_number>"!).

Pleased to see pretty good error handling too, there's not really any cases where the client will be left hanging.

Nice work! 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants