Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using .includes in your router #35

Open
tspeed90 opened this issue Apr 13, 2018 · 0 comments
Open

Using .includes in your router #35

tspeed90 opened this issue Apr 13, 2018 · 0 comments

Comments

@tspeed90
Copy link
Member

Most of your words are pretty safe, but when using includes the way you are in router, you risk accidentally handling files in a way you didn't mean to. If you end up creating another route that is ('signup-error') for example, if your router sees 'signup' in it first, it will route there instead of where you mean to. Using url.includes('/signup/') is safer I believe.

Having said that, I think my team's project looks the same...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant