Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

You're putting your variables inside your SQL queries (queries.js) #74

Open
bobbysebolao opened this issue Aug 16, 2019 · 0 comments
Open

Comments

@bobbysebolao
Copy link

Instead of:

INSERT INTO users (name, hashed_password) VALUES ('${userName}', '${password}');

it'd be more secure to separate the username and password variables from your SQL query (it protects against script injections), like so:

      .query(
        "INSERT INTO users (name, hashed_password) VALUES ($1, $2)",
        [
          userName,
          password
        ])
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant