Skip to content

Commit 7864e52

Browse files
committed
Adjust webpack config to webpack 5 node polyfill removal
1 parent 9c9e5b3 commit 7864e52

File tree

4 files changed

+20
-15
lines changed

4 files changed

+20
-15
lines changed

packages/react-error-overlay/package.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -83,5 +83,8 @@
8383
"/fixtures/",
8484
"setupJest.js"
8585
]
86+
},
87+
"dependencies": {
88+
"path-browserify": "^1.0.0"
8689
}
8790
}

packages/react-error-overlay/src/utils/unmapper.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
import StackFrame from './stack-frame';
1010
import { getSourceMap } from './getSourceMap';
1111
import { getLinesAround } from './getLinesAround';
12-
import path from 'path';
12+
import path from 'path-browserify';
1313

1414
function count(search: string, string: string): number {
1515
// Count starts at -1 because a do-while loop always runs at least once

packages/react-error-overlay/webpack.config.js

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -38,10 +38,11 @@ module.exports = {
3838
optimization: {
3939
nodeEnv: false,
4040
},
41-
node: {
42-
fs: 'empty',
43-
process: false,
44-
},
41+
// todo: Update before final webpack 5 release
42+
// node: {
43+
// fs: 'empty',
44+
// process: false,
45+
// },
4546
performance: {
4647
hints: false,
4748
},

packages/react-scripts/config/webpack.config.js

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -726,16 +726,17 @@ module.exports = function(webpackEnv) {
726726
].filter(Boolean),
727727
// Some libraries import Node modules but don't use them in the browser.
728728
// Tell Webpack to provide empty mocks for them so importing them works.
729-
node: {
730-
module: 'empty',
731-
dgram: 'empty',
732-
dns: 'mock',
733-
fs: 'empty',
734-
http2: 'empty',
735-
net: 'empty',
736-
tls: 'empty',
737-
child_process: 'empty',
738-
},
729+
// todo: Update before final webpack 5 release
730+
// node: {
731+
// module: 'empty',
732+
// dgram: 'empty',
733+
// dns: 'mock',
734+
// fs: 'empty',
735+
// http2: 'empty',
736+
// net: 'empty',
737+
// tls: 'empty',
738+
// child_process: 'empty',
739+
// },
739740
// Turn off performance processing because we utilize
740741
// our own hints via the FileSizeReporter
741742
performance: false,

0 commit comments

Comments
 (0)