linter class_overrides_all_trait_methods should not be triggered by require this as

Summary: The linter `class_overrides_all_trait_methods` was incorrectly treating `require this as` as `require class` constraints.

Reviewed By: geralt-encore

Differential Revision: D74739487

fbshipit-source-id: 7e867e403b7396fec15da932622a94d6ae296a37

Author: Francesco Zappa Nardelli

hphp/hack/src/lints/linter_class_overrides_trait.ml

@@ -114,9 +114,8 @@ let handler =
         List.filter_map
           ~f:(fun (u, k) ->
             match k with
-            | RequireClass
-            | RequireThisAs ->
-              trait_name_from_hint (snd u)
+            | RequireClass -> trait_name_from_hint (snd u)
+            | RequireThisAs
             | RequireExtends
             | RequireImplements ->
               None)

hphp/hack/test/lint/override_trait_method_require_this_as.php

@@ -0,0 +1,19 @@
+<?hh
+
+<<file:__EnableUnstableFeatures('require_constraints')>>
+
+trait T {
+  require this as C;
+
+  public function foo(): void {}
+  public function bar(): void {}
+}
+
+class C {
+  <<__Override>>
+  public function foo(): void {}
+}
+
+class D extends C {
+  use T;
+}

hphp/hack/test/lint/override_trait_method_require_this_as.php.exp

@@ -0,0 +1 @@
+No lint errors