Skip to content

Build fails: fallthrough annotation does not directly precede switch label #559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yurivict opened this issue May 9, 2025 · 5 comments
Assignees

Comments

@yurivict
Copy link

yurivict commented May 9, 2025

FAILED: proxygen/lib/CMakeFiles/proxygen.dir/__/__/generated/proxygen/lib/http/HTTPCommonHeaders.cpp.o 
/usr/bin/c++ -DFMT_SHARED -DGFLAGS_IS_A_DLL=0 -Dproxygen_EXPORTS -I/wrkdirs/usr/ports/www/proxygen/work/proxygen-2025.05.05.00 -I/wrkdirs/usr/ports/www/proxygen/work/.build/generated -isystem /usr/local/include -O2 -pipe -fstack-protector-strong -fno-strict-aliasing  -fPIC -DGLOG_USE_GLOG_EXPORT -O2 -pipe -fstack-protector-strong -fno-strict-aliasing  -fPIC -DGLOG_USE_GLOG_EXPORT  -DNDEBUG -std=c++17 -fPIC -Wall -Wextra -Wno-noexcept-type -Wno-unused-parameter -Wno-missing-field-initializers -Wno-nullability-completeness -Wno-deprecated-register -Wno-register -Wno-unused-value -pthread -MD -MT proxygen/lib/CMakeFiles/proxygen.dir/__/__/generated/proxygen/lib/http/HTTPCommonHeaders.cpp.o -MF proxygen/lib/CMakeFiles/proxygen.dir/__/__/generated/proxygen/lib/http/HTTPCommonHeaders.cpp.o.d -o proxygen/lib/CMakeFiles/proxygen.dir/__/__/generated/proxygen/lib/http/HTTPCommonHeaders.cpp.o -c /wrkdirs/usr/ports/www/proxygen/work/.build/generated/proxygen/lib/http/HTTPCommonHeaders.cpp
/wrkdirs/usr/ports/www/proxygen/work/.build/generated/proxygen/lib/http/HTTPCommonHeaders.cpp:150:7: error: fallthrough annotation does not directly precede switch label
  150 |       [[fallthrough]];
      |       ^
/wrkdirs/usr/ports/www/proxygen/work/.build/generated/proxygen/lib/http/HTTPCommonHeaders.cpp:176:7: error: fallthrough annotation does not directly precede switch label
  176 |       [[fallthrough]];
      |       ^
2 errors generated.
ninja: build stopped: subcommand failed.
*** Error code 1

log

Version: 2025.05.05.00
clang-19
FreeBSD 14.2

@afrind
Copy link
Contributor

afrind commented May 9, 2025

Yes, we saw this started failing and are working on a solution. See #558 for a potential solution, though it doesn't pass all our internal tests yet.

@afrind afrind self-assigned this May 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants
@yurivict @afrind and others