[LOCAL][0.83] Skip Hermes nightly override on stable branches#56582
Merged
motiz88 merged 1 commit intoApr 23, 2026
Merged
Conversation
The test-ios-rntester, test-ios-helloworld actions and the test_android_helloworld job unconditionally run use-hermes-nightly.js, which replaces the pinned Hermes version with the latest nightly from npm. On stable/release branches this is wrong: the pinned version from version.properties should be used instead. Add a `use-hermes-nightly` input (default true for backward compat) to both composite actions, and guard the nightly override steps behind it. In test-all.yml, pass `!endsWith(github.ref_name, '-stable')` so that pushes to *-stable branches use the pinned Hermes version.
meta-cla
Bot
added
the
CLA Signed
|
Warning JavaScript API change detected This PR commits an update to
This change was flagged as: |
motiz88
changed the title
Contributor
Author
|
Talked to @cipolleschi, landing in the branch only and we will probably need a more elaborate solution to land in main in support of new branch cuts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
test-ios-rntester,test-ios-helloworldcomposite actions and the inlinetest_android_helloworldjob intest-all.ymlunconditionally runuse-hermes-nightly.js, which replaces the pinned Hermes version with the latest nightly from npm. On stable/release branches, this is incorrect — the pinned version fromversion.propertiesshould be used.This wasn't a problem before because the Hermes V0 nightlies happened to be ABI-compatible, but as of the April 22 nightly (
0.17.0-commitly-202604221946), JSI symbol exports appear to be broken, causing linker failures intest_ios_rntesterand downstream jobs.The
prebuild-ios-coreworkflow already handles this correctly via ause-hermes-nightlyinput gated by!endsWith(github.ref_name, '-stable'). This PR applies the same pattern to the three remaining places.Changelog
Changelog: [Internal]
Test Plan
CI — the
test_ios_rntesterandtest_ios_helloworldjobs should now use the pinned Hermes 0.14.1 on 0.83-stable instead of the broken nightly.