Skip to content

Commit 21c1d51

Browse files
authored
[DevTools] Don't attempt to draw bounding box if inspected element is not a Suspense (#35097)
1 parent be48396 commit 21c1d51

File tree

2 files changed

+9
-1
lines changed

2 files changed

+9
-1
lines changed

packages/react-devtools-shared/src/devtools/store.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -669,6 +669,10 @@ export default class Store extends EventEmitter<{
669669
return element;
670670
}
671671

672+
containsSuspense(id: SuspenseNode['id']): boolean {
673+
return this._idToSuspense.has(id);
674+
}
675+
672676
getSuspenseByID(id: SuspenseNode['id']): SuspenseNode | null {
673677
const suspense = this._idToSuspense.get(id);
674678
if (suspense === undefined) {

packages/react-devtools-shared/src/devtools/views/SuspenseTab/SuspenseRects.js

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -511,7 +511,11 @@ function SuspenseRectsContainer({
511511
let selectedEnvironment = null;
512512
if (isRootSelected) {
513513
selectedEnvironment = rootEnvironment;
514-
} else if (inspectedElementID !== null) {
514+
} else if (
515+
inspectedElementID !== null &&
516+
// TODO: Separate inspected element and inspected Suspense and use the inspected Suspense ID here.
517+
store.containsSuspense(inspectedElementID)
518+
) {
515519
const selectedSuspenseNode = store.getSuspenseByID(inspectedElementID);
516520
if (
517521
selectedSuspenseNode !== null &&

0 commit comments

Comments
 (0)