Don't mutate while diffing

Author: eps1lon

packages/react-devtools-shared/src/__tests__/storeComponentFilters-test.js

@@ -910,14 +910,21 @@ describe('Store component filters', () => {
 
     expect(store).toMatchInlineSnapshot(`
       [root]
-        ▾ <Activity name="/">
-          ▾ <Suspense>
-              <h1>
-            ▾ <main>
-              ▾ <Layout>
-                  <Activity name="/blog">
+        ▾ <Root>
+          ▾ <Activity name="/">
+            ▾ <Suspense>
+                <h1>
+              ▾ <main>
+                ▾ <Layout>
+                  ▾ <Activity name="/blog">
+                      <h2>
+                    ▾ <section>
+                      ▾ <Page>
+                        ▾ <Suspense>
+                            <div>
       [suspense-root]  rects={[{x:1,y:2,width:4,height:1}, {x:1,y:2,width:13,height:1}]}
-        <Suspense name="Unknown" rects={[{x:1,y:2,width:4,height:1}, {x:1,y:2,width:13,height:1}]}>
+        <Suspense name="Root" rects={[{x:1,y:2,width:4,height:1}, {x:1,y:2,width:13,height:1}]}>
+          <Suspense name="Page" rects={[{x:1,y:2,width:9,height:1}]}>
     `);
   });
 });

packages/react-devtools-shared/src/backend/fiber/renderer.js

@@ -1492,8 +1492,8 @@ export function attach(
             isInActivitySlice = false;
           } else {
             // We're not filtering by activity slice after all.
-            // TODO: This is not sent to the frontend.
-            componentFilter.isEnabled = false;
+            // Don't mark the filter as disabled here.
+            // Otherwise updateComponentFilters() will think no enabled filter was changed.
           }
           break;
         default:
@@ -1546,6 +1546,7 @@ export function attach(
       const filter = componentFilters[i];
       if (filter.type === ComponentFilterActivitySlice && filter.isEnabled) {
         const instance = idToDevToolsInstanceMap.get(filter.activityID);
+        console.log({filter, instance});
         if (instance !== undefined && instance.kind === FIBER_INSTANCE) {
           nextActivitySlice = instance.data;
         }