Use comment nodes for empty components - #5451
Conversation
This makes more sense and avoids DOM nesting problems.  (ReactSimpleEmptyComponent isn't used here but React Native can use it as it currently does.)
|
Only reference I can find is #4550 which shouldn't actually be an issue because we work around it in our |
|
👍 excellent |
|
With unencrypted HTTP, you'll need to set a |
|
I thought Knockout is a client-side library only? |
|
Yup, though Knockout bindings are just attributes/comments in the HTML, so it was common to just render the initial page containing all the knockout-y bits with whatever server-side templating language you were using, then call |
|
Got it – thanks for the explanation! I don't think this will be an issue for us. |
There was a problem hiding this comment.
You don't use this anywhere… is the thinking that this would be used in RN?
There was a problem hiding this comment.
Yeah. (I even mentioned that in my PR description. ;))
Use comment nodes for empty components
|
Interesting! Would really like to use this, but it looks like this code hasn't been released yet. Any idea why this will be released? |
|
@martijnrusschen This will be released in v15, coming soon. |
|
👍 |
|
Should this mean that React can render |
|
@alxndr That's unrelated, sorry. |
Use comment nodes for empty components

This makes more sense and avoids DOM nesting problems.
(ReactSimpleEmptyComponent isn't used here but React Native can use it as it currently does, with View.)