Skip to content

Remove react/addons - #6285

Merged
gaearon merged 1 commit into
react:masterfrom
gaearon:no-addons
Mar 17, 2016
Merged

gaearon merged 1 commit into
react:masterfrom
gaearon:no-addons

Conversation

@gaearon

@gaearon gaearon commented Mar 17, 2016

Copy link
Copy Markdown
Contributor

Not sure what the plan is with 15.0 but accessing react/addons in the CommonJS environment has been deprecated since 0.14 betas. This commit removes react/addons entry point.

If the consumer uses CommonJS, they need to switch to using react-addons-<addon name> package as we warned during 0.14. If the consumer uses addons-enabled UMD build, they don’t need to change anything.

Can we get this into v15?

@jimfb

jimfb commented Mar 17, 2016

Copy link
Copy Markdown
Contributor

As long as this won't break the browser-with-addons builds, I'm good with this. 👍

@zpao manages the building/packaging, so it's worth pinging him for a go ahead.

@gaearon

gaearon commented Mar 17, 2016

Copy link
Copy Markdown
Contributor Author

As far as I can see the UMD addons build uses ReactWithAddons which stays. Only the file that contained the warning is removed, and that one was specifically in the npm React package folder and outside the source directory.

@zpao

zpao commented Mar 17, 2016

Copy link
Copy Markdown
Contributor

I wish we had remembered to do this before rc but that's ok. 👍

gaearon added a commit that referenced this pull request Mar 17, 2016
@gaearon
gaearon merged commit 8046cbd into react:master Mar 17, 2016
@gaearon
gaearon deleted the no-addons branch March 17, 2016 19:26
mrizwanashiq pushed a commit to mrizwanashiq/react that referenced this pull request Jun 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants