Skip to content

Fix IE11 placeholder textContent value bug. - #7002

Merged
jimfb merged 1 commit into
react:masterfrom
jimfb:value-detach
Jun 9, 2016
Merged

jimfb merged 1 commit into
react:masterfrom
jimfb:value-detach

Conversation

@jimfb

@jimfb jimfb commented Jun 9, 2016

Copy link
Copy Markdown
Contributor

Fix IE11 placeholder textContent value bug.

Pop quiz: What does IE11 give you if...

var node = document.createElement('textarea');
node.placeholder = 'placeholder';
node.textContent = 'textContent';
assert(typeof node.value === 'string');
alert((typeof node.value)+':'+node.value);

Apparently placeholder detaches value, or something.

In case you're wondering, no, this bug shows up in 15.0.1, so it was not caused by my recent value change. It was something else introduced prior to v15.

Fixes #6984

@jimfb

jimfb commented Jun 9, 2016

Copy link
Copy Markdown
Contributor Author

cc @spicyj

@sophiebits

Copy link
Copy Markdown
Contributor

Does Edge have the same problem?

@jimfb

jimfb commented Jun 9, 2016

Copy link
Copy Markdown
Contributor Author

@spicyj No, edge does the right thing.

@ghost ghost added the CLA Signed label Jun 9, 2016
@jimfb
jimfb merged commit f0b140d into react:master Jun 9, 2016
@zpao zpao added this to the 15-next milestone Jun 14, 2016
zpao pushed a commit that referenced this pull request Jun 14, 2016
@zpao zpao modified the milestones: 15-next, 15.2.0 Jun 14, 2016
mrizwanashiq pushed a commit to mrizwanashiq/react that referenced this pull request Jun 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants