Make "unexpected batch number" a warning - #7133
Conversation
This was added to catch internal errors in React but doesn't seem to be doing much good except frustrating people more when their apps throw (react#6895, FB-internal t11950821). Until more proper error boundaries land, let's make this a warning.
|
Seems reasonable. Are we sure that the "unexpected batch number" is due to prior errors in the user's application, and not due to a subtle bug in React? We've seen a bunch of super subtle/complex bugs related to this code path, and it isn't super clear to me that people are hitting this do to recoverable bugs in user land rather than a subtle bug in React land. Regardless, I suppose there isn't really a reason to make this fatal, so this change seems reasonable. |
|
The two people in #6895 who saw it, saw it because of an earlier error – and we did in the FB task too. So it's possible there could be subtle bugs in React that this would catch (which is why I'm leaving it instead of removing it completely) but I don't think we've seen any evidence of that so far. |
This was added to catch internal errors in React but doesn't seem to be doing much good except frustrating people more when their apps throw (react#6895, FB-internal t11950821). Until more proper error boundaries land, let's make this a warning.
This was added to catch internal errors in React but doesn't seem to be doing much good except frustrating people more when their apps throw (#6895, FB-internal t11950821). Until more proper error boundaries land, let's make this a warning.