Skip to content

fix batchedUpdates return value - #7444

Merged
sophiebits merged 2 commits into
masterfrom
unknown repository
Aug 9, 2016
Merged

sophiebits merged 2 commits into
masterfrom
unknown repository

Conversation

@ghost

@ghost ghost commented Aug 8, 2016

Copy link
Copy Markdown

When I used ReactDOM.unstable_batchedUpdates with redux middleware to fix this issue (reduxjs/react-redux#292) it breaks redux middleware return value.

@ghost

ghost commented Aug 8, 2016

Copy link
Copy Markdown
Author

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

@facebook-github-bot

Copy link
Copy Markdown
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@ghost ghost added the CLA Signed label Aug 8, 2016

it('unstable_batchedUpdates should return value from a callback', function() {
var result = ReactDOM.unstable_batchedUpdates(function() {
return 42

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a semicolon here?

(@zpao don't we lint for semicolons?)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, though apparently it's only a warning so didn't fail CI (https://travis-ci.org/facebook/react/jobs/150690962#L285)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I didn't realize we had warnings.

@sophiebits

Copy link
Copy Markdown
Contributor

This seems reasonable, I think. If you add the semicolon we can merge.

In the meantime, you can always work around this with something like

var x;
ReactDOM.unstable_batchedUpdates(function() {
  x = 42;
});

@ghost ghost added the CLA Signed label Aug 8, 2016
@sophiebits

Copy link
Copy Markdown
Contributor

Thanks!

@sophiebits sophiebits added this to the 15-next milestone Aug 9, 2016
@zpao zpao modified the milestones: 15-next, 15.4.0 Oct 4, 2016
zpao pushed a commit that referenced this pull request Oct 4, 2016
mrizwanashiq pushed a commit to mrizwanashiq/react that referenced this pull request Jun 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants