Skip to content

Copy all SVG child nodes when using setting innerHTML in IE - #7618

Merged
zpao merged 1 commit into
react:masterfrom
zpao:svg-innerhtml
Aug 31, 2016
Merged

zpao merged 1 commit into
react:masterfrom
zpao:svg-innerhtml

Conversation

@zpao

@zpao zpao commented Aug 30, 2016

Copy link
Copy Markdown
Contributor

This is a followup to #6982, which missed half the nodes. We missed this because the test that was written depended on broken JSDOM behavior (will report shortly).

Test Plan:

I also renamed the test file to fit our convention.

@sophiebits

Copy link
Copy Markdown
Contributor

I hope this isn't n^2 in some browsers.

@sophiebits

Copy link
Copy Markdown
Contributor

Thanks.

@zpao
zpao merged commit c73d863 into react:master Aug 31, 2016
@zpao zpao added this to the 15-next milestone Aug 31, 2016
@zpao zpao modified the milestones: 15.3.2, 15-next Sep 8, 2016
zpao added a commit that referenced this pull request Sep 15, 2016
mrizwanashiq pushed a commit to mrizwanashiq/react that referenced this pull request Jun 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants