Skip to content

Remove plain object warning for createElement & cloneElement - #7724

Merged
sophiebits merged 1 commit into
react:masterfrom
spudly:master
Sep 14, 2016
Merged

sophiebits merged 1 commit into
react:masterfrom
spudly:master

Conversation

@spudly

@spudly spudly commented Sep 14, 2016

Copy link
Copy Markdown
Contributor

Fixes #7718 by removing the warning altogether, as suggested by @spicyj.

This is basically an exact revert of 17683e (Pull Request #6134).

@ghost

ghost commented Sep 14, 2016

Copy link
Copy Markdown

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

@ghost

ghost commented Sep 14, 2016

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@sophiebits
sophiebits merged commit b2297ae into react:master Sep 14, 2016
@sophiebits

Copy link
Copy Markdown
Contributor

Thanks!

@spudly

spudly commented Sep 14, 2016

Copy link
Copy Markdown
Contributor Author

🎉🎉🎉

@zpao zpao modified the milestones: 15.3.2, 15-next Sep 15, 2016
zpao pushed a commit that referenced this pull request Sep 15, 2016
(cherry picked from commit b2297ae)
jfschwarz added a commit to jfschwarz/substyle that referenced this pull request Dec 18, 2016
>=15.3.2 because that's where
react/react#7724 landed
mrizwanashiq pushed a commit to mrizwanashiq/react that referenced this pull request Jun 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants