Skip to content

add dependencies to react-test-renderer and react-addons - #8467

Merged
gaearon merged 1 commit into
react:masterfrom
kweiberth:add_dependencies
Dec 1, 2016
Merged

add dependencies to react-test-renderer and react-addons#8467
gaearon merged 1 commit into
react:masterfrom
kweiberth:add_dependencies

Conversation

@kweiberth

@kweiberth kweiberth commented Nov 30, 2016

Copy link
Copy Markdown
Contributor

What and Why:

  • When using npm version 2, object-assign and fbjs were not installed
  • This PR adds object-assign and fbjs as explicit dependencies to both react-test-renderer and react-addons

kweiberth
add dependencies to react-test-renderer and react-addons
7aee6ce 
**What** and **Why**:

* When using npm version 2, `object-assign` and `fbjs` were not getting properly installed
* This PR adds `object-assign` and `fbjs` as explicit dependencies to both `react-test-renderer` and `react-addons`
@kweiberth kweiberth mentioned this pull request Nov 30, 2016
Closed
@kweiberth

kweiberth commented Nov 30, 2016

Copy link
Copy Markdown
Contributor Author

Does react-addons for sure need fbjs as a dependency?

@gaearon

gaearon commented Nov 30, 2016

Copy link
Copy Markdown
Collaborator

Can you show me what is test renderer using from fbjs?

@kweiberth

kweiberth commented Nov 30, 2016

Copy link
Copy Markdown
Contributor Author 
Cannot find module 'fbjs/lib/invariant' from 'ReactComponentEnvironment.js'

      at Resolver.resolveModule (node_modules/jest/node_modules/jest-cli/node_modules/jest-resolve/build/index.js:151:17)
      at Object.<anonymous> (node_modules/react-test-renderer/lib/ReactComponentEnvironment.js:16:17)
      at Object.<anonymous> (node_modules/react-test-renderer/lib/ReactTestRenderer.js:21:33)

@gaearon

gaearon commented Nov 30, 2016

Copy link
Copy Markdown
Collaborator

Oh right, it ships with a complete renderer copy now..
I think there is no harm in adding fbjs to addons too just in case.
If anything it would be consistent.

@gaearon gaearon self-assigned this Nov 30, 2016
@gaearon gaearon added this to the 15-next milestone Dec 1, 2016
@gaearon
gaearon merged commit 7cd2602 into react:master Dec 1, 2016
@gaearon

gaearon commented Dec 1, 2016

Copy link
Copy Markdown
Collaborator

LGTM

@gaearon gaearon mentioned this pull request Dec 5, 2016
Closed
@gghez

gghez commented Dec 7, 2016

Copy link
Copy Markdown

react-test-renderer v15.4.1 is the latest and does not include this fix. How is it planned to be released?

@gaearon

gaearon commented Jan 6, 2017

Copy link
Copy Markdown
Collaborator

It will be released as part of 15.4.2 (shortly).

@gaearon gaearon modified the milestones: 15-hipri, 15-lopri, 15.4.2 Jan 6, 2017
gaearon pushed a commit that referenced this pull request Jan 6, 2017
@kweiberth @gaearon
add dependencies to react-test-renderer and react-addons (#8467)
3ec576e 
**What** and **Why**:

* When using npm version 2, `object-assign` and `fbjs` were not getting properly installed
* This PR adds `object-assign` and `fbjs` as explicit dependencies to both `react-test-renderer` and `react-addons`
(cherry picked from commit 7cd2602)
@gaearon

gaearon commented Jan 6, 2017

Copy link
Copy Markdown
Collaborator

Should be fixed if you update all packages to 15.4.2.
Thank you!

richardgiddings pushed a commit to richardgiddings/menu that referenced this pull request Jan 9, 2017
@AnonymousApplication
Update to packages to fix react/react#8467. This was an issue affecti…
d6f604e 
…ng testing.
richardgiddings pushed a commit to richardgiddings/menu that referenced this pull request Jan 9, 2017
@AnonymousApplication
Update to packages to fix react/react#8467. This was an issue affecti…
edd3565 
…ng testing.
acusti pushed a commit to brandcast/react that referenced this pull request Mar 15, 2017
@kweiberth @acusti
add dependencies to react-test-renderer and react-addons (react#8467)
7857f73 
**What** and **Why**:

* When using npm version 2, `object-assign` and `fbjs` were not getting properly installed
* This PR adds `object-assign` and `fbjs` as explicit dependencies to both `react-test-renderer` and `react-addons`
@renovate renovate Bot mentioned this pull request Feb 2, 2018
Closed
1 task
laurinenas pushed a commit to laurinenas/react that referenced this pull request May 28, 2018
@kweiberth @laurinenas
add dependencies to react-test-renderer and react-addons (react#8467)
b407f8e 
**What** and **Why**:

* When using npm version 2, `object-assign` and `fbjs` were not getting properly installed
* This PR adds `object-assign` and `fbjs` as explicit dependencies to both `react-test-renderer` and `react-addons`
NMinhNguyen referenced this pull request in enzymejs/react-shallow-renderer Jan 29, 2020
@kweiberth @gaearon
add dependencies to react-test-renderer and react-addons (#8467)
701df24 
**What** and **Why**:

* When using npm version 2, `object-assign` and `fbjs` were not getting properly installed
* This PR adds `object-assign` and `fbjs` as explicit dependencies to both `react-test-renderer` and `react-addons`
mrizwanashiq pushed a commit to mrizwanashiq/react that referenced this pull request Jun 25, 2026
@kweiberth @gaearon
add dependencies to react-test-renderer and react-addons (react#8467)
98b1d6d 
**What** and **Why**:

* When using npm version 2, `object-assign` and `fbjs` were not getting properly installed
* This PR adds `object-assign` and `fbjs` as explicit dependencies to both `react-test-renderer` and `react-addons`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@montusardar1234 montusardar1234 montusardar1234 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@gaearon gaearon

Labels

CLA Signed

Projects

None yet

Milestone

15.4.2

Development

Successfully merging this pull request may close these issues.

5 participants

@kweiberth @gaearon @gghez @montusardar1234 @facebook-github-bot