Fix an assertion failure #616
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for fb-oss-glean canceled.
|
meta-cla
bot
added
the
CLA Signed
`Id::operator-=(a,b)` throws when a == b, because you're not supposed to make an invalid Id from a valid Id. So instead we use `uint64_t` to represent the page offsets, because those are not necesarily valid Ids. This assertion triggered when I tried to add units to the Haskell indexer, I'm not sure why it hasn't triggered before.
simonmar
force-pushed
the
ownership-assertion
branch
from
066d949 to
9e12793
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Id::operator-=(a,b)throws when a == b, because you're not supposed to make an invalid Id from a valid Id. So instead we useuint64_tto represent the page offsets, because those are not necesarily valid Ids.This assertion triggered when I tried to add units to the Haskell indexer, I'm not sure why it hasn't triggered before.