Skip to content

Human footer suggests suppress tokens that IssueKind::parse does not recognize for eight sections #1828

Description

@BartWaardenburg

Follow-up from the review of #1820, which fixed the singular/plural mismatch for the Unused files section. The same surface has a wider gap: section_suppress_rule in crates/cli/src/report/human/mod.rs emits suppression hint tokens that fallow_types::suppress::parse_suppression_target does not recognize, so following the printed hint produces a comment that suppresses nothing and then surfaces a stale-suppression finding.

Verified unparseable footer tokens (present only as config_key/mcp_issue_type, no alias): unused-exports, unused-types, unused-dependencies, unused-enum-members, unused-class-members, unresolved-imports, unlisted-dependencies, duplicate-exports.

Not broken (registered aliases): circular-dependencies, unused-store-members, unprovided-injects, unrendered-components, unused-component-props, unused-component-emits.

Two-part fix:

  1. Correct the emitted tokens (or add plural aliases where that is the better contract; the dependency sections may want no hint at all, since those findings live in package.json where inline comments are impossible).
  2. Add a parse-roundtrip guard test asserting every token section_suppress_rule can emit parses via parse_suppression_target, so this whole surface stays locked down.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions