Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email address already registered #146

Open
aspdotmike opened this issue May 3, 2017 · 7 comments
Open

Email address already registered #146

aspdotmike opened this issue May 3, 2017 · 7 comments

Comments

@aspdotmike
Copy link

I keep getting the message email is already registered even though the email entered has never been invited before.

@KrauseFx
Copy link
Member

KrauseFx commented May 4, 2017

Could you share the server log when running it? Thanks 👍

@aspdotmike
Copy link
Author

2017-05-03T18:18:51.017182+00:00 app[web.1]: Processing by InviteController#submit as HTML
2017-05-03T18:18:51.017244+00:00 app[web.1]: Parameters: {"utf8"=>"✓", "authenticity_token"=>"v7+xxxxxxx==", "first_name"=>"Jennie", "last_name"=>"Slow", "email"=>"[email protected]", "commit"=>"Get Beta Access"}
2017-05-03T18:18:51.027714+00:00 app[web.1]: Creating a new tester: [email protected] - Jennie Slow
2017-05-03T18:18:52.384600+00:00 app[web.1]: Tester [email protected] exists in iTunesConnect but not on application
2017-05-03T18:18:52.384857+00:00 app[web.1]: Addding tester to application in group(s): ["External Testers"]
2017-05-03T18:18:54.492505+00:00 heroku[router]: at=info method=POST path="/submit" host=arrivalreq.herokuapp.com request_id=09353b85-4d5e-47be-bb45-3c0fd0c7f118 fwd="88.131.223.94" dyno=web.1 connect=1ms service=3486ms status=200 bytes=2135 protocol=http
2017-05-03T18:18:54.475498+00:00 app[web.1]: Done
2017-05-03T18:18:54.482584+00:00 app[web.1]: Rendered invite/index.html.erb within layouts/application (2.7ms)

@aspdotmike
Copy link
Author

the user gets properly added. it's just that even though its successful, I get the email already exists everytime.

@taquitos
Copy link
Collaborator

taquitos commented May 4, 2017

I'm having a difficult time repro'ing this. One way I am able to repro is by doing the following:

  1. Add tester to app (default external tester)
  2. Remove tester from app
  3. Add tester (get message)

This is expected now, though. Since the new TestFlight changes, testers get added to a pool of testers when you add them to your app. When you remove the tester from the app, they still remain in the pool of testers un "Users and Roles"
So even if they don't show up in the App's external testers, they are still associated with your account.
One really good way to test this is to create a new tester using a gmail account like I did:
my email is taquitos@gmail, but I created a new tester of taquitos+josh1@gmail (you probably know, anything past the + is ignored by gmail and gets forwarded to taquitos@gmail) and everything worked as expected:

Started POST "/submit" for ::1 at 2017-05-04 12:29:00 -0700
Processing by InviteController#submit as HTML
  Parameters: {"utf8"=>"✓", "authenticity_token"=>"RbkWk0lrlxAyMrR4zCFGctc3XMNobxUDNmYSPoqS3GLxWdan2Pz3YouNye3ukBLUJD3NxYboEI4jIHbr8uNsOQ==", "first_name"=>"Josh", "last_name"=>"Test2", "email"=>"[email protected]", "commit"=>"Get Beta Access"}
Creating a new tester: [email protected] - Josh Test2
Successfully created tester [email protected]
Addding tester to application in group(s): ["External Testers"]
Done

@arshiacont
Copy link

From my recent experience doing tests: If you remove a user from the APP section of iTunesConnect, the user is not actually removed! You can still see her/him in the USERS & ROLES/External Testers of iTunesConnect.
The only way to completely remove testers from iTunesConnect (in order to be able to add them later) is to do it from the USERS & ROLES and not from the APP section!
Now, what does this entail to as far as Fastlane Boarding/Pilot ... .

@aspdotmike
Copy link
Author

aspdotmike commented May 7, 2017 via email

@owurman
Copy link

owurman commented May 10, 2017

I'm getting this too. It seems that the code in boarding_service.rb treats this as a message worth relaying the user, even though it's not a big deal (and, as observed above, expected).

I think the message should only be "Email address is already registered" if the tester exists and was already added to external testers

It's perfectly plausible that the user (or admin) removed him/herself from the external testers group, or that the user is signing up for a beta on a different app under the same developer account.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants