Skip to content

Commit 81ffe4f

Browse files
committed
Fix PHP 8.1 "strlen(null)" exception in PhabricatorAuthAccountView
Summary: `strlen()` was used in Phabricator to check if a generic value is a non-empty string. This behavior is deprecated since PHP 8.1. Phorge adopts `phutil_nonempty_string()` as a replacement. Note: this may highlight other absurd input values that might be worth correcting instead of just ignoring. If phutil_nonempty_string() throws an exception in your instance, report it to Phorge to evaluate and fix that specific corner case. ``` ERROR 8192: strlen(): Passing null to parameter freebsd#1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/auth/view/PhabricatorAuthAccountView.php:66] ``` Closes T15900 Test Plan: Try to register an account via LDAP. Reviewers: O1 Blessed Committers, valerio.bozzolan Reviewed By: O1 Blessed Committers, valerio.bozzolan Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno Maniphest Tasks: T15900 Differential Revision: https://we.phorge.it/D25761
1 parent a110aa4 commit 81ffe4f

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/applications/auth/view/PhabricatorAuthAccountView.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ public function render() {
6363
));
6464

6565
$account_uri = $account->getAccountURI();
66-
if (strlen($account_uri)) {
66+
if (phutil_nonempty_string($account_uri)) {
6767

6868
// Make sure we don't link a "javascript:" URI if a user somehow
6969
// managed to get one here.

0 commit comments

Comments
 (0)