Skip to content

Commit aad704d

Browse files
committed
Mark created Pholio mockups as new objects to fix empty Feed transaction entries
Summary: When creating a Pholio mockup, `setIsCreateTransaction(true)` to avoid an empty `Transaction` field in the Feed and avoid `strncmp()` complaining about a null value being passed. This is very similar to T15659 about Differential Diffs. ``` ERROR 8192: strncmp(): Passing null to parameter freebsd#1 ($string1) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/policy/query/PhabricatorPolicyQuery.php:314] ``` Closes T15679 Test Plan: 1. Create a new Pholio mockup via `/pholio/create/` 2. Go to `/feed/transactions/query/all/` 3. Compare entries in the `Transaction` column before (empty ones) and after (no empty ones) applying the patch. Reviewers: O1 Blessed Committers, valerio.bozzolan Reviewed By: O1 Blessed Committers, valerio.bozzolan Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno Maniphest Tasks: T15679 Differential Revision: https://we.phorge.it/D25600
1 parent 29cbb0a commit aad704d

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

src/applications/pholio/controller/PholioMockEditController.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -108,6 +108,7 @@ public function handleRequest(AphrontRequest $request) {
108108
foreach ($mock_xactions as $type => $value) {
109109
$xactions[$type] = id(new PholioTransaction())
110110
->setTransactionType($type)
111+
->setIsCreateTransaction($is_new)
111112
->setNewValue($value);
112113
}
113114

0 commit comments

Comments
 (0)