Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sleep/resume overflow #53

Open
fengb opened this issue May 26, 2020 · 1 comment
Open

Sleep/resume overflow #53

fengb opened this issue May 26, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@fengb
Copy link
Owner

fengb commented May 26, 2020

When the timer doesn't fire for... days, the counter overflows and does bad stuff. This really only happens when the laptop / browser goes to sleep.

We should add a hook to disable/reenable the runloop upon sleep/wake.

@fengb fengb added the bug Something isn't working label May 26, 2020
@fengb
Copy link
Owner Author

fengb commented May 30, 2020

There's also been a regression with background processing. setInterval doesn't seem to be as guaranteed to run as setTimeout (although neither is actually guaranteed). The recommendation is the use a WebWorker for the timer, which feels a little heavy but it can work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant