New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use inheritance, not composition #17

Open

feth opened this issue Mar 24, 2012 · 4 comments

Owner

feth commented Mar 24, 2012

that's a feeling @GaelVaroquaux has.

Owner Author

feth commented Mar 24, 2012

coded in the train, will push later. The quick n dirty implementation patch is less than 30 lines long

Collaborator

GaelVaroquaux commented Mar 25, 2012

Awesome. Wanna see the patch :)

Owner Author

feth commented Mar 25, 2012

Hm, that estimation was wrong :)

25 insertions, 18 deletions

Owner Author

feth commented Mar 25, 2012

And I pushed to master instead of "composition"... well it's early in the morning

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment