fix sprintf WIP

Author: fglock

src/main/java/org/perlonjava/operators/SprintfFormatParser.java

@@ -270,8 +270,10 @@ FormatSpecifier parseSpecifier() {
 
             spec.endPos = pos;
             spec.raw = input.substring(spec.startPos, spec.endPos);
-            // // ADD THIS DEBUG LINE:
-            // System.err.println("DEBUG: spec.raw='" + spec.raw + "', vectorFlag=" + spec.vectorFlag + ", widthFromArg=" + spec.widthFromArg + ", conversionChar='" + spec.conversionChar + "'");
+
+            // Add debug here to check the state before returning
+            System.err.println("DEBUG: Before return - isValid=" + spec.isValid +
+                          ", errorMessage='" + spec.errorMessage + "'");
 
             // Mark as invalid if we found spaces in the format
             if (hasInvalidSpace) {
@@ -282,6 +284,10 @@ FormatSpecifier parseSpecifier() {
                 validateSpecifier(spec);
             }
 
+            // Add debug after validation
+            System.err.println("DEBUG: After validation - isValid=" + spec.isValid +
+                          ", errorMessage='" + spec.errorMessage + "'");
+
             return spec;
         }
 
@@ -297,8 +303,9 @@ Integer parseNumber() {
         }
 
             void validateSpecifier(FormatSpecifier spec) {
-                // // ADD THIS DEBUG LINE:
-                // System.err.println("DEBUG: Validating spec: raw='" + spec.raw + "', vectorFlag=" + spec.vectorFlag + ", widthFromArg=" + spec.widthFromArg);
+                System.err.println("DEBUG validateSpecifier: raw='" + spec.raw +
+                    "', vectorFlag=" + spec.vectorFlag +
+                    ", conversionChar='" + spec.conversionChar + "'");
             // Special case: %*v formats are valid
             if (spec.vectorFlag && spec.widthFromArg) {
                 // This is a valid vector format with custom separator
@@ -313,11 +320,14 @@ void validateSpecifier(FormatSpecifier spec) {
                 return;
             }
 
-            // Check for vector formats BEFORE other validations
+            // Check for vector formats FIRST (before %n check)
             if (spec.vectorFlag) {
                 // Vector flag is only valid with certain conversions
                 String validVectorConversions = "diouxXbBs";
+                System.err.println("DEBUG: Checking vector conversion '" + spec.conversionChar +
+                      "' in '" + validVectorConversions + "'");
                 if (validVectorConversions.indexOf(spec.conversionChar) < 0) {
+                    System.err.println("DEBUG: Setting invalid for vector format");
                     spec.isValid = false;
                     spec.errorMessage = "INVALID";
                     return;
@@ -375,17 +385,6 @@ void validateSpecifier(FormatSpecifier spec) {
                 }
             }
 
-            // Validate vector flag combinations
-            if (spec.vectorFlag) {
-                // Vector flag is only valid with certain conversions
-                String validVectorConversions = "diouxXbBs";
-                if (validVectorConversions.indexOf(spec.conversionChar) < 0) {
-                    spec.isValid = false;
-                    spec.errorMessage = "INVALID";
-                    return;
-                }
-            }
-
             // Validate flag combinations
             validateFlags(spec);
 

src/main/java/org/perlonjava/operators/SprintfOperator.java

@@ -50,6 +50,14 @@ public static RuntimeScalar sprintf(RuntimeScalar runtimeScalar, RuntimeList lis
                 result.append(literal);
                 charsWritten += literal.length();
             } else if (element instanceof SprintfFormatParser.FormatSpecifier spec) {
+                // Check if spec is invalid FIRST
+                if (!spec.isValid) {
+                    String formatted = processFormatSpecifier(spec, list, argIndex, formatter);
+                    result.append(formatted);
+                    charsWritten += formatted.length();
+                    continue;
+                }
+
                 if (spec.conversionChar == 'n') {
                     // %n doesn't produce output, but does consume an argument
                     handlePercentN(spec, list, argIndex);
@@ -70,7 +78,7 @@ public static RuntimeScalar sprintf(RuntimeScalar runtimeScalar, RuntimeList lis
 
                     // Update argument index if not using positional parameters
                     // BUT don't update if the specifier was invalid
-                    if (spec.parameterIndex == null && spec.conversionChar != '%' && spec.isValid) {
+                    if (spec.parameterIndex == null && spec.conversionChar != '%') {
                         argIndex = updateArgIndex(spec, argIndex);
                     }
                 }
@@ -330,6 +338,8 @@ private static int updateArgIndex(SprintfFormatParser.FormatSpecifier spec,
      * Handle invalid format specifiers.
      */
     private static String handleInvalidSpecifier(SprintfFormatParser.FormatSpecifier spec) {
+        System.err.println("DEBUG handleInvalidSpecifier: raw='" + spec.raw +
+            "', errorMessage='" + spec.errorMessage + "'");
         String formatOnly = spec.raw;
         String trailing = "";