optimization - migrate from INVOKEINTERFACE to INVOKEVIRTUAL

Author: fglock

src/main/java/org/perlonjava/codegen/EmitLiteral.java

@@ -89,8 +89,8 @@ public static void emitArrayLiteral(EmitterVisitor emitterVisitor, ArrayLiteralN
         }
 
         // Convert the array to a reference (array literals produce references)
-        mv.visitMethodInsn(Opcodes.INVOKEINTERFACE, "org/perlonjava/runtime/RuntimeDataProvider",
-                "createReference", "()Lorg/perlonjava/runtime/RuntimeScalar;", true);
+        mv.visitMethodInsn(Opcodes.INVOKEVIRTUAL, "org/perlonjava/runtime/RuntimeBaseEntity",
+                "createReference", "()Lorg/perlonjava/runtime/RuntimeScalar;", false);
 
         emitterVisitor.ctx.logDebug("visit(ArrayLiteralNode) end");
     }

src/main/java/org/perlonjava/codegen/EmitLogicalOperator.java

@@ -65,7 +65,7 @@ static void emitLogicalAssign(EmitterVisitor emitterVisitor, BinaryOperatorNode
         // Stack is [left, left]
 
         // Convert the result to a boolean
-        mv.visitMethodInsn(Opcodes.INVOKEINTERFACE, "org/perlonjava/runtime/RuntimeDataProvider", getBoolean, "()Z", true);
+        mv.visitMethodInsn(Opcodes.INVOKEVIRTUAL, "org/perlonjava/runtime/RuntimeBaseEntity", getBoolean, "()Z", false);
         // Stack is [left, boolean]
 
         // If the boolean value is true, jump to endLabel (we keep the left operand)
@@ -121,7 +121,7 @@ static void emitLogicalOperator(EmitterVisitor emitterVisitor, BinaryOperatorNod
         // Stack is [left, left]
 
         // Convert the result to a boolean
-        mv.visitMethodInsn(Opcodes.INVOKEINTERFACE, "org/perlonjava/runtime/RuntimeDataProvider", getBoolean, "()Z", true);
+        mv.visitMethodInsn(Opcodes.INVOKEVIRTUAL, "org/perlonjava/runtime/RuntimeBaseEntity", getBoolean, "()Z", false);
         // Stack is [left, boolean]
 
         // If the left operand boolean value is true, return left operand

src/main/java/org/perlonjava/codegen/EmitOperator.java

@@ -40,7 +40,7 @@ static void emitOperator(Node node, EmitterVisitor emitterVisitor) {
                 operatorHandler.getClassName(),
                 operatorHandler.getMethodName(),
                 operatorHandler.getDescriptor(),
-                operatorHandler.getMethodType() == Opcodes.INVOKEINTERFACE
+                false
         );
 
         // Handle context
@@ -269,10 +269,10 @@ static void handleChompBuiltin(EmitterVisitor emitterVisitor, OperatorNode node)
         // Accept the operand in LIST context.
         node.operand.accept(emitterVisitor.with(RuntimeContextType.LIST));
         // Invoke the interface method for the operator.
-        mv.visitMethodInsn(Opcodes.INVOKEINTERFACE,
-                "org/perlonjava/runtime/RuntimeDataProvider",
+        mv.visitMethodInsn(Opcodes.INVOKEVIRTUAL,
+                "org/perlonjava/runtime/RuntimeBaseEntity",
                 node.operator,
-                "()Lorg/perlonjava/runtime/RuntimeScalar;", true);
+                "()Lorg/perlonjava/runtime/RuntimeScalar;", false);
         // If the context is VOID, pop the result from the stack.
         handleVoidContext(emitterVisitor);
     }
@@ -660,11 +660,11 @@ static void handleCreateReference(EmitterVisitor emitterVisitor, OperatorNode no
                 }
             } else {
                 node.operand.accept(emitterVisitor.with(RuntimeContextType.LIST));
-                emitterVisitor.ctx.mv.visitMethodInsn(Opcodes.INVOKEINTERFACE,
-                        "org/perlonjava/runtime/RuntimeDataProvider",
+                emitterVisitor.ctx.mv.visitMethodInsn(Opcodes.INVOKEVIRTUAL,
+                        "org/perlonjava/runtime/RuntimeBaseEntity",
                         "createReference",
                         "()Lorg/perlonjava/runtime/RuntimeScalar;",
-                        true);
+                        false);
             }
             handleVoidContext(emitterVisitor);
         }

src/main/java/org/perlonjava/codegen/EmitOperatorChained.java

@@ -70,11 +70,11 @@ static public void emitChainedComparison(EmitterVisitor emitterVisitor, BinaryOp
             for (int i = 1; i < operators.size(); i++) {
                 // Check previous result
                 emitterVisitor.ctx.mv.visitInsn(Opcodes.DUP);
-                emitterVisitor.ctx.mv.visitMethodInsn(Opcodes.INVOKEINTERFACE,
-                        "org/perlonjava/runtime/RuntimeDataProvider",
+                emitterVisitor.ctx.mv.visitMethodInsn(Opcodes.INVOKEVIRTUAL,
+                        "org/perlonjava/runtime/RuntimeBaseEntity",
                         "getBoolean",
                         "()Z",
-                        true);
+                        false);
                 emitterVisitor.ctx.mv.visitJumpInsn(Opcodes.IFEQ, falseLabel);
 
                 // Previous was true, do next comparison